Ensure dialogs are centered on browser windows.

Ensure dialogs are centered on browser windows.

Also, remove notifications no longer needed after r272421.

BUG=364831
TEST=as in bug

[Robert Sesek, 2014-07-28 21:11:27]

https://codereview.chromium.org/420413002/diff/1/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/420413002/diff/1/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2233: // up the hierarchy
to the devtools container view to avoid that.
Add to the comment as to what happens when you don't have a devtools view open?

[Avi (use Gerrit), 2014-07-28 21:21:21]

https://codereview.chromium.org/420413002/diff/1/chrome/browser/ui/cocoa/tabs...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/420413002/diff/1/chrome/browser/ui/cocoa/tabs...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:2233: // up the hierarchy
to the devtools container view to avoid that.
On 2014/07/28 21:11:26, rsesek wrote:
> Add to the comment as to what happens when you don't have a devtools view
open?

Done.

[Robert Sesek, 2014-07-28 21:22:30]

lgtm

[Avi (use Gerrit), 2014-07-28 21:23:14]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-07-28 21:25:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/420413002/20001

[commit-bot: I haz the power, 2014-07-28 23:13:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[commit-bot: I haz the power, 2014-07-29 01:00:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 01:00:31]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

[Avi (use Gerrit), 2014-07-29 20:34:59]

On 2014/07/29 01:00:31, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel on tryserver.chromium.mac
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)

Grrr. Several tests are failing.
ConstrainedWindowSheetControllerTest.AddToInactiveTab in particular since
inactive tabs are removed from the view hierarchy, so they don't have three
superviews deep.

[Avi (use Gerrit), 2014-08-07 20:56:26]

Please take another look. This time, the tests pass... well, except for the one
I removed because you can't host these things at the root any more.

[Robert Sesek, 2014-08-07 21:52:33]

LGTM

[Avi (use Gerrit), 2014-08-07 21:55:52]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-08-07 22:19:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/420413002/40001

[commit-bot: I haz the power, 2014-08-08 00:39:03]

Change committed as 288176