Ensure dialogs are centered on browser windows.

chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h"
 
 #import "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h"
 #import "testing/gtest_mac.h"
 
@@ skipping 57 matching lines @@
  protected:
   virtual ~ConstrainedWindowSheetControllerTest() {
   }
 
   virtual void SetUp() OVERRIDE {
     CocoaTest::SetUp();
 
     // Center the window so that the sheet doesn't go offscreen.
     [test_window() center];
 
+    // The real view setup is quite a few levels deep; recreate something
+    // similar.
+    NSRect dummy_rect = NSMakeRect(0, 0, 50, 50);
+    tab_view_parent_ = [test_window() contentView];
+    for (int i = 0; i < 3; ++i) {
+      base::scoped_nsobject<NSView> new_view(
+          [[NSView alloc] initWithFrame:dummy_rect]);
+      [tab_view_parent_ addSubview:new_view.get()];
+      tab_view_parent_ = new_view.get();
+    }
+
     // Create two dummy tabs and make the first one active.
-    NSRect dummyRect = NSMakeRect(0, 0, 50, 50);
     tab_views_.reset([[NSMutableArray alloc] init]);
     for (int i = 0; i < 2; ++i) {
       base::scoped_nsobject<NSView> view(
-          [[NSView alloc] initWithFrame:dummyRect]);
+          [[NSView alloc] initWithFrame:dummy_rect]);
       [tab_views_ addObject:view];
     }
-    tab0_.reset([[tab_views_ objectAtIndex:0] retain]);
-    tab1_.reset([[tab_views_ objectAtIndex:1] retain]);
+    tab0_ = [tab_views_ objectAtIndex:0];
+    tab1_ = [tab_views_ objectAtIndex:1];
     ActivateTabView(tab0_);
 
     // Create a test sheet.
     sheet_window_.reset([[NSWindow alloc]
-        initWithContentRect:dummyRect
+        initWithContentRect:dummy_rect
                   styleMask:NSTitledWindowMask
                     backing:NSBackingStoreBuffered
                       defer:NO]);
     [sheet_window_ setReleasedWhenClosed:NO];
     sheet_.reset([[CustomConstrainedWindowSheet alloc]
         initWithCustomWindow:sheet_window_]);
 
     controller_.reset([[ConstrainedWindowSheetController
             controllerForParentWindow:test_window()] retain]);
     EXPECT_TRUE(controller_);
     EXPECT_FALSE([ConstrainedWindowSheetController controllerForSheet:sheet_]);
   }
 
   virtual void TearDown() OVERRIDE {
     sheet_.reset();
     sheet_window_.reset();
     CocoaTest::TearDown();
   }
 
   void ActivateTabView(NSView* tab_view) {
-    for (NSView* view in tab_views_.get()) {
+    for (NSView* view in tab_views_.get())
       [view removeFromSuperview];
-    }
-    [[test_window() contentView] addSubview:tab_view];
-    active_tab_view_.reset([tab_view retain]);
+    [tab_view_parent_ addSubview:tab_view];
+    active_tab_view_ = tab_view;
 
     ConstrainedWindowSheetController* controller =
         [ConstrainedWindowSheetController
             controllerForParentWindow:test_window()];
     EXPECT_TRUE(controller);
     [controller parentViewDidBecomeActive:active_tab_view_];
   }
 
   NSRect GetViewFrameInScreenCoordinates(NSView* view) {
     NSRect rect = [view convertRect:[view bounds] toView:nil];
@@ skipping 10 matching lines @@
 
   CGFloat GetSheetYOffset(NSRect sheet_frame, NSView* parent_view) {
     return NSMaxY(sheet_frame) -
            NSMaxY(GetViewFrameInScreenCoordinates(parent_view));
   }
 
   base::scoped_nsobject<NSWindow> sheet_window_;
   base::scoped_nsobject<CustomConstrainedWindowSheet> sheet_;
   base::scoped_nsobject<ConstrainedWindowSheetController> controller_;
   base::scoped_nsobject<NSMutableArray> tab_views_;
-  base::scoped_nsobject<NSView> active_tab_view_;
-  base::scoped_nsobject<NSView> tab0_;
-  base::scoped_nsobject<NSView> tab1_;
+  NSView* tab_view_parent_;
+  NSView* active_tab_view_;
+  NSView* tab0_;
+  NSView* tab1_;
 };
 
 // Test showing then hiding the sheet.
 TEST_F(ConstrainedWindowSheetControllerTest, ShowHide) {
   EXPECT_FALSE([sheet_window_ isVisible]);
   [controller_ showSheet:sheet_ forParentView:active_tab_view_];
   EXPECT_TRUE([ConstrainedWindowSheetController controllerForSheet:sheet_]);
   EXPECT_TRUE([sheet_window_ isVisible]);
 
   [controller_ closeSheet:sheet_];
@@ skipping 41 matching lines @@
   EXPECT_TRUE(controller2);
   EXPECT_NSNE(controller_, controller2);
 
   [controller2 showSheet:sheet_ forParentView:[parent_window2 contentView]];
   EXPECT_NSEQ(controller2,
               [ConstrainedWindowSheetController controllerForSheet:sheet_]);
 
   [parent_window2 close];
 }
 
-// Test that using a top level parent view works.
-TEST_F(ConstrainedWindowSheetControllerTest, TopLevelView) {
-  NSView* parentView = [[test_window() contentView] superview];
-  [controller_ parentViewDidBecomeActive:parentView];
-
-  EXPECT_FALSE([sheet_window_ isVisible]);
-  [controller_ showSheet:sheet_ forParentView:parentView];
-  EXPECT_TRUE([ConstrainedWindowSheetController controllerForSheet:sheet_]);
-  EXPECT_TRUE([sheet_window_ isVisible]);
-  VerifySheetXPosition([sheet_window_ frame], parentView);
-}
-
 // Test that resizing sheet works.
 TEST_F(ConstrainedWindowSheetControllerTest, Resize) {
   [controller_ showSheet:sheet_ forParentView:active_tab_view_];
 
   NSRect old_frame = [sheet_window_ frame];
 
   NSRect sheet_frame;
   sheet_frame.size = NSMakeSize(NSWidth(old_frame) + 100,
                                 NSHeight(old_frame) + 50);
   sheet_frame.origin = [controller_ originForSheet:sheet_
@@ skipping 28 matching lines @@
 // Test resizing parent window keeps the sheet anchored.
 TEST_F(ConstrainedWindowSheetControllerTest, ResizeParentWindow) {
   [controller_ showSheet:sheet_ forParentView:active_tab_view_];
   CGFloat sheet_offset =
       GetSheetYOffset([sheet_window_ frame], active_tab_view_);
 
   // Test 3x3 different parent window sizes.
   CGFloat insets[] = {-10, 0, 10};
   NSRect old_frame = [test_window() frame];
 
-  for (size_t x = 0; x < sizeof(insets) / sizeof(CGFloat); x++) {
-    for (size_t y = 0; y < sizeof(insets) / sizeof(CGFloat); y++) {
+  for (size_t x = 0; x < arraysize(insets); x++) {
+    for (size_t y = 0; y < arraysize(insets); y++) {
       NSRect resized_frame = NSInsetRect(old_frame, insets[x], insets[y]);
       [test_window() setFrame:resized_frame display:YES];
       NSRect sheet_frame = [sheet_window_ frame];
 
       // Y pos should track parent view's position.
       EXPECT_EQ(sheet_offset, GetSheetYOffset(sheet_frame, active_tab_view_));
 
       // X pos should be centered on parent view.
       VerifySheetXPosition(sheet_frame, active_tab_view_);
     }
   }
 }
 
 // Test system sheets.
 TEST_F(ConstrainedWindowSheetControllerTest, SystemSheet) {
   base::scoped_nsobject<ConstrainedWindowSystemSheetTest> system_sheet(
       [[ConstrainedWindowSystemSheetTest alloc] init]);
   base::scoped_nsobject<NSAlert> alert([[NSAlert alloc] init]);
   [system_sheet setAlert:alert];
 
   EXPECT_FALSE([[alert window] isVisible]);
-  [controller_ showSheet:system_sheet
-                 forParentView:active_tab_view_];
+  [controller_ showSheet:system_sheet forParentView:active_tab_view_];
   EXPECT_TRUE([[alert window] isVisible]);
 
   [controller_ closeSheet:system_sheet];
   EXPECT_FALSE([[alert window] isVisible]);
   EXPECT_EQ(kSystemSheetReturnCode, [system_sheet returnCode]);
 }
 
 // Test showing a system sheet on an inactive tab.
 TEST_F(ConstrainedWindowSheetControllerTest, SystemSheetAddToInactiveTab) {
   base::scoped_nsobject<ConstrainedWindowSystemSheetTest> system_sheet(
       [[ConstrainedWindowSystemSheetTest alloc] init]);
   base::scoped_nsobject<NSAlert> alert([[NSAlert alloc] init]);
   [system_sheet setAlert:alert];
 
   EXPECT_FALSE([[alert window] isVisible]);
-  [controller_ showSheet:system_sheet
-                 forParentView:tab1_];
+  [controller_ showSheet:system_sheet forParentView:tab1_];
   EXPECT_FALSE([[alert window] isVisible]);
 
   ActivateTabView(tab1_);
   EXPECT_TRUE([[alert window] isVisible]);
   EXPECT_EQ(1.0, [[alert window] alphaValue]);
 
   [controller_ closeSheet:system_sheet];
 }