Issue 42041: Changes docking in the following ways:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42041: Changes docking in the following ways:... (Closed)

Created:
11 years, 9 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changes docking in the following ways: . Dock icons for window docking positions could go offscreen before. . It was possible to show the maximize indicator on the wrong screen. This was because equals was not comparing the monitor bounds. . Tweaks to color, size and animation from Glen. BUG=none TEST=make sure there are no bugs with docking tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11391

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -207 lines)			Patch
A	chrome/app/theme/dock_tab_high.png	View	Binary file		0 comments	Download
A	chrome/app/theme/dock_tab_max.png	View	Binary file		0 comments	Download
A	chrome/app/theme/dock_tab_wide.png	View	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/dock_info.h	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/dock_info.cc	View	10 chunks	+86 lines, -64 lines	0 comments	Download
M	chrome/browser/views/tabs/dragged_tab_controller.cc	View	7 chunks	+78 lines, -138 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages