Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 42041: Changes docking in the following ways:... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by sky
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Changes docking in the following ways: . Dock icons for window docking positions could go offscreen before. . It was possible to show the maximize indicator on the wrong screen. This was because equals was not comparing the monitor bounds. . Tweaks to color, size and animation from Glen. BUG=none TEST=make sure there are no bugs with docking tabs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -207 lines) Patch
A chrome/app/theme/dock_tab_high.png View Binary file 0 comments Download
A chrome/app/theme/dock_tab_max.png View Binary file 0 comments Download
A chrome/app/theme/dock_tab_wide.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/dock_info.h View 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/dock_info.cc View 10 chunks +86 lines, -64 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 7 chunks +78 lines, -138 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 2 (0 generated)
sky
7 years, 11 months ago (2009-03-10 21:24:25 UTC) #1
Ben Goodger (Google)
7 years, 11 months ago (2009-03-10 21:34:27 UTC) #2
OK
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd