Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: net/quic/test_tools/quic_test_packet_maker.cc

Issue 420313005: Land Recent QUIC Changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0723
Patch Set: change QUIC packet size to 1350 Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/test_tools/quic_test_packet_maker.cc
diff --git a/net/quic/test_tools/quic_test_packet_maker.cc b/net/quic/test_tools/quic_test_packet_maker.cc
index 7f0835f8bdfe5a1666a6a93669f4f6de899e7cbc..345b7b5f3e9e41a79ab971a805c38f9baf194be2 100644
--- a/net/quic/test_tools/quic_test_packet_maker.cc
+++ b/net/quic/test_tools/quic_test_packet_maker.cc
@@ -61,8 +61,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckAndRstPacket(
header.fec_flag = false;
header.fec_group = 0;
- QuicAckFrame ack(MakeAckFrame(largest_received, least_unacked));
- ack.received_info.delta_time_largest_observed = QuicTime::Delta::Zero();
+ QuicAckFrame ack(MakeAckFrame(largest_received));
+ ack.delta_time_largest_observed = QuicTime::Delta::Zero();
QuicFrames frames;
frames.push_back(QuicFrame(&ack));
QuicCongestionFeedbackFrame feedback;
@@ -74,10 +74,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckAndRstPacket(
}
QuicStopWaitingFrame stop_waiting;
- if (version_ > QUIC_VERSION_15) {
- stop_waiting.least_unacked = least_unacked;
- frames.push_back(QuicFrame(&stop_waiting));
- }
+ stop_waiting.least_unacked = least_unacked;
+ frames.push_back(QuicFrame(&stop_waiting));
QuicRstStreamFrame rst(stream_id, error_code, 0);
frames.push_back(QuicFrame(&rst));
@@ -122,8 +120,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckPacket(
header.fec_flag = false;
header.fec_group = 0;
- QuicAckFrame ack(MakeAckFrame(largest_received, least_unacked));
- ack.received_info.delta_time_largest_observed = QuicTime::Delta::Zero();
+ QuicAckFrame ack(MakeAckFrame(largest_received));
+ ack.delta_time_largest_observed = QuicTime::Delta::Zero();
QuicCongestionFeedbackFrame feedback;
feedback.type = kTCP;
@@ -137,10 +135,8 @@ scoped_ptr<QuicEncryptedPacket> QuicTestPacketMaker::MakeAckPacket(
}
QuicStopWaitingFrame stop_waiting;
- if (version_ > QUIC_VERSION_15) {
- stop_waiting.least_unacked = least_unacked;
- frames.push_back(QuicFrame(&stop_waiting));
- }
+ stop_waiting.least_unacked = least_unacked;
+ frames.push_back(QuicFrame(&stop_waiting));
scoped_ptr<QuicPacket> packet(
BuildUnsizedDataPacket(&framer, header, frames).packet);

Powered by Google App Engine
This is Rietveld 408576698