Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 420243002: Refactoring IsUserAllowedInSession and GetCachedValue (Closed)

Created:
6 years, 4 months ago by Roman Sorokin (ftl)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring IsUserAllowedInSession and GetCachedValue BUG=388279 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287522

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -53 lines) Patch
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 1 chunk +13 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 7 chunks +25 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 8 chunks +31 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Roman Sorokin (ftl)
dzhioev@, please take a look.
6 years, 4 months ago (2014-07-28 13:31:14 UTC) #1
dzhioev (left Google)
On 2014/07/28 13:31:14, Roman Sorokin wrote: > dzhioev@, please take a look. LGTM
6 years, 4 months ago (2014-08-04 11:08:55 UTC) #2
Roman Sorokin (ftl)
The CQ bit was checked by rsorokin@chromium.org
6 years, 4 months ago (2014-08-04 11:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/420243002/1
6 years, 4 months ago (2014-08-04 11:20:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-04 11:31:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-04 11:33:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/37030) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/2359) ios_rel_device ...
6 years, 4 months ago (2014-08-04 11:33:04 UTC) #7
Roman Sorokin (ftl)
The CQ bit was checked by rsorokin@chromium.org
6 years, 4 months ago (2014-08-05 09:27:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsorokin@chromium.org/420243002/20001
6 years, 4 months ago (2014-08-05 09:28:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 10:38:28 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 12:45:10 UTC) #11
Message was sent while issue was closed. 
Change committed as 287522

Powered by Google App Engine
This is Rietveld 408576698