chrome/browser/chromeos/login/users/chrome_user_manager.cc - Issue 420243002: Refactoring IsUserAllowedInSession and GetCachedValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager.cc

Issue 420243002: Refactoring IsUserAllowedInSession and GetCachedValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screens/user_selection_screen.cc ('k') | chrome/browser/chromeos/login/users/multi_profile_user_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/chrome_user_manager.cc

diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager.cc b/chrome/browser/chromeos/login/users/chrome_user_manager.cc

index 53a2eaf91f72312cb699a1ce90d348eaaff7d589..1e405fa25a87bc4bbe0eff36792df424ae655f29 100644

--- a/chrome/browser/chromeos/login/users/chrome_user_manager.cc

+++ b/chrome/browser/chromeos/login/users/chrome_user_manager.cc

@@ -198,9 +198,9 @@ user_manager::UserList ChromeUserManager::GetUsersAdmittedForMultiProfile()

++it) {

if ((*it)->GetType() == user_manager::USER_TYPE_REGULAR &&

!(*it)->is_logged_in()) {

- MultiProfileUserController::UserAllowedInSessionResult check =

- multi_profile_user_controller_->IsUserAllowedInSession(

- (*it)->email());

+ MultiProfileUserController::UserAllowedInSessionReason check;

+ multi_profile_user_controller_->IsUserAllowedInSession((*it)->email(),

+ &check);

if (check ==

MultiProfileUserController::NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS) {

return user_manager::UserList();