Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/shell/shell_test_base.h

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/shell/context.cc ('K') | « mojo/shell/in_process_dynamic_service_runner_unittest.cc ('k') | mojo/shell/shell_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell_test_base.h
diff --git a/mojo/shell/shell_test_base.h b/mojo/shell/shell_test_base.h
index eb446ecee6d67a0aba8e339f41f04f161eb411f7..7c61844431c5a9d9fc1ca658d790f56d2d462bbc 100644
--- a/mojo/shell/shell_test_base.h
+++ b/mojo/shell/shell_test_base.h
@@ -48,8 +48,8 @@ class ShellTestBase : public testing::Test {
private:
scoped_ptr<net::test_server::EmbeddedTestServer> test_server_;
- base::MessageLoop message_loop_;
Context shell_context_;
+ base::MessageLoop message_loop_;
DISALLOW_COPY_AND_ASSIGN(ShellTestBase);
};
« mojo/shell/context.cc ('K') | « mojo/shell/in_process_dynamic_service_runner_unittest.cc ('k') | mojo/shell/shell_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698