mojo/shell/in_process_dynamic_service_runner_unittest.cc - Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/in_process_dynamic_service_runner_unittest.cc

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/shell/in_process_dynamic_service_runner_unittest.cc

diff --git a/mojo/shell/in_process_dynamic_service_runner_unittest.cc b/mojo/shell/in_process_dynamic_service_runner_unittest.cc

index 6ebb1a6492ecd3d7fc3739fdcbf1990f279cf8fc..2ade6ec1f2b43b33e8be0c7efe3703ec8c93fe10 100644

--- a/mojo/shell/in_process_dynamic_service_runner_unittest.cc

+++ b/mojo/shell/in_process_dynamic_service_runner_unittest.cc

@@ -10,8 +10,9 @@ namespace mojo {

namespace shell {

TEST(InProcessDynamicServiceRunnerTest, NotStarted) {

- base::MessageLoop loop;

Context context;

+ base::MessageLoop loop;

+ context.Init();

InProcessDynamicServiceRunner runner(&context);

// Shouldn't crash or DCHECK on destruction.

}