Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: mojo/shell/child_process_host_unittest.cc

Issue 420143003: mojo: shell::Context should outlive the shell MessageLoop (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/child_process_host_unittest.cc
diff --git a/mojo/shell/child_process_host_unittest.cc b/mojo/shell/child_process_host_unittest.cc
index 97bc96dca08d25d873a7ec287644c404a7de3634..8104ec309bad42d6302d3783eedcac523490122b 100644
--- a/mojo/shell/child_process_host_unittest.cc
+++ b/mojo/shell/child_process_host_unittest.cc
@@ -38,6 +38,7 @@ TEST_F(ChildProcessHostTest, Basic) {
scoped_ptr<base::MessagePump>(new common::MessagePumpMojo()));
Context context;
jamesr 2014/07/28 20:11:27 any reason not to move this context c'tor up befor
tim (not reviewing) 2014/07/28 22:16:37 Oops, done.
+ context.Init();
TestChildProcessHostDelegate child_process_host_delegate;
ChildProcessHost child_process_host(&context,
&child_process_host_delegate,
« no previous file with comments | « mojo/shell/android/mojo_main.cc ('k') | mojo/shell/context.h » ('j') | mojo/shell/context.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698