mojo: shell::Context should outlive the shell MessageLoop

mojo/shell/child_process_host_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Note: This file also tests child_process.*.
 
 #include "mojo/shell/child_process_host.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 19 matching lines @@
     base::MessageLoop::current()->QuitWhenIdle();
   }
 };
 
 typedef testing::Test ChildProcessHostTest;
 
 TEST_F(ChildProcessHostTest, Basic) {
   base::MessageLoop message_loop(
       scoped_ptr<base::MessagePump>(new common::MessagePumpMojo()));
 
   Context context;

[jamesr, 2014/07/28 20:11:27]

any reason not to move this context c'tor up before the MessageLoop allocation
like the other ones?

[tim (not reviewing), 2014/07/28 22:16:37]

Oops, done.

+  context.Init();
   TestChildProcessHostDelegate child_process_host_delegate;
   ChildProcessHost child_process_host(&context,
                                       &child_process_host_delegate,
                                       ChildProcess::TYPE_TEST);
   child_process_host.Start();
   message_loop.Run();
   int exit_code = child_process_host.Join();
   VLOG(2) << "Joined child: exit_code = " << exit_code;
   EXPECT_EQ(0, exit_code);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace shell
 }  // namespace mojo