Issue 420113003: components: Fix a couple of the TODO(GYP) todos.

Issue 420113003: components: Fix a couple of the TODO(GYP) todos. (Closed)

Created:
6 years, 4 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
brettw

CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, jochen (gone - plz use gerrit), awong, Dirk Pranke, jamesr, scottmg, blundell, Garrett Casto

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

components: Fix a couple of the TODO(GYP) todos. BUG=None TEST=gn gen out/Debug_gn + build the effected targets with ninja. R=brettw@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286362

Patch Set 1 #

Patch Set 2 : do third_party/fips181 as well - it is trivial #

Patch Set 3 : REBASE #

Patch Set 4 : REBASE #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -10 lines)			Patch
M	components/autofill/content/browser/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
M	components/autofill/core/browser/BUILD.gn	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	components/invalidation/BUILD.gn	View	1 2 3	3 chunks	+4 lines, -5 lines	0 comments	Download
M	components/policy/core/browser/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/search_engines/BUILD.gn	View		2 chunks	+1 line, -1 line	0 comments	Download
A	third_party/fips181/BUILD.gn	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

brettw

Sorry, I accidentally marked this with my "Done" label so was ignoring it. LGTM

6 years, 4 months ago (2014-07-29 20:34:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/420113003/30001

6 years, 4 months ago (2014-07-30 00:25:19 UTC) #6

SeRya

6 years, 4 months ago (2014-07-30 10:45:57 UTC) #8

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/428123002/ by serya@chromium.org.

The reason for reverting is: Likely caused build falure:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\components\invalidation\invalidation_test_support.invalidator_test_template.obj.rsp
/c ..\..\components\invalidation\invalidator_test_template.cc
/Foobj\components\invalidation\invalidation_test_support.invalidator_test_template.obj
/Fdobj\components\invalidation_test_support.cc.pdb 
c:\b\build\slave\win\build\src\components\invalidation\invalidator_test_template.h(87)
: fatalerror C1083: Cannot open include file:
'google/cacheinvalidation/types.pb.h': No such file or directory
ninja: build stopped: subcommand failed.

http://build.chromium.org/p/chromium/builders/Win/builds/22963/steps/compile/...

.

Expand Messages | Collapse Messages