Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Side by Side Diff: components/autofill/core/browser/BUILD.gn

Issue 420113003: components: Fix a couple of the TODO(GYP) todos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: REBASE Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/autofill/content/browser/BUILD.gn ('k') | components/invalidation/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 autofill_enable_sync = !is_android_webview_build 7 autofill_enable_sync = !is_android_webview_build
8 } else { 8 } else {
9 autofill_enable_sync = true 9 autofill_enable_sync = true
10 } 10 }
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 sources += get_target_outputs(":regexes") 131 sources += get_target_outputs(":regexes")
132 132
133 deps = [ 133 deps = [
134 ":regexes", 134 ":regexes",
135 "//base", 135 "//base",
136 "//base:i18n", 136 "//base:i18n",
137 "//base:prefs", 137 "//base:prefs",
138 "//components/autofill/core/common", 138 "//components/autofill/core/common",
139 "//components/keyed_service/core", 139 "//components/keyed_service/core",
140 "//components/os_crypt", 140 "//components/os_crypt",
141 "//components/pref_registry",
141 "//components/resources", 142 "//components/resources",
142 "//components/strings", 143 "//components/strings",
143 "//components/webdata/common", 144 "//components/webdata/common",
144 "//google_apis", 145 "//google_apis",
145 "//skia", 146 "//skia",
146 "//sql", 147 "//sql",
148 "//third_party/fips181",
147 "//third_party/icu", 149 "//third_party/icu",
148 "//third_party/libaddressinput:util", 150 "//third_party/libaddressinput:util",
149 "//third_party/libphonenumber", 151 "//third_party/libphonenumber",
150 "//ui/base", 152 "//ui/base",
151 "//ui/gfx", 153 "//ui/gfx",
152 "//ui/gfx/geometry", 154 "//ui/gfx/geometry",
153 "//url", 155 "//url",
154 #'../third_party/fips181/fips181.gyp:fips181', TODO(GYP)
155 # TODO(GYP) also remove libjingle_stub_config below when this is added: 156 # TODO(GYP) also remove libjingle_stub_config below when this is added:
156 #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP) 157 #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP)
157 #'pref_registry', TODO(GYP)
158 ] 158 ]
159 159
160 configs += [ "//content:libjingle_stub_config" ] 160 configs += [ "//content:libjingle_stub_config" ]
161 direct_dependent_configs = [ ":autofill_browser_config" ] 161 direct_dependent_configs = [ ":autofill_browser_config" ]
162 162
163 if (autofill_enable_sync) { 163 if (autofill_enable_sync) {
164 deps += [ "//sync" ] 164 deps += [ "//sync" ]
165 } else { 165 } else {
166 sources -= [ 166 sources -= [
167 "webdata/autofill_profile_syncable_service.cc", 167 "webdata/autofill_profile_syncable_service.cc",
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 deps = [ 243 deps = [
244 ":browser", 244 ":browser",
245 ":test_support", 245 ":test_support",
246 "//components/resources", 246 "//components/resources",
247 "//components/strings", 247 "//components/strings",
248 "//testing/gmock", 248 "//testing/gmock",
249 "//third_party/libphonenumber", 249 "//third_party/libphonenumber",
250 #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP) 250 #'../third_party/libjingle/libjingle.gyp:libjingle', TODO(GYP)
251 ] 251 ]
252 } 252 }
OLDNEW
« no previous file with comments | « components/autofill/content/browser/BUILD.gn ('k') | components/invalidation/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698