Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 420113002: Remove some GN Build files related to blink from build/secondary tree. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, abarth-chromium, eseidel, jamesr, Dirk Pranke
Project:
chromium
Visibility:
Public.

Description

Remove some GN Build files related to blink from build/secondary tree. Blink now has the real implementations of these files in their repo: platform -> https://src.chromium.org/viewvc/blink?view=rev&revision=172998 wtf -> https://src.chromium.org/viewvc/blink?view=rev&revision=172321 BUG=None TEST=trybots R=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -437 lines) Patch
D build/secondary/third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments Download
D build/secondary/third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +0 lines, -364 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 5 months ago (2014-07-27 01:42:34 UTC) #1
brettw
lgtm
6 years, 4 months ago (2014-07-27 18:38:33 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-07 02:30:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/420113002/1
6 years, 4 months ago (2014-08-07 02:34:03 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 03:00:27 UTC) #5
Message was sent while issue was closed.
Change committed as 287947

Powered by Google App Engine
This is Rietveld 408576698