Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 420103003: Update Chromium Buildbot Monitor extension. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update Chromium Buildbot Monitor extension. It is using a now defunct webkit notifications API and thus with recent versions of Chrome a notification balloon that used to appear in the right bottom does not appear anymore. This patches makes the changes necessary so the notification balloon appears again. BUG=None TEST=None R=peter@chromium.org,miket@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286141

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove show() call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/common/extensions/docs/examples/extensions/buildbot/bg.js View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
ptal.
6 years, 5 months ago (2014-07-26 21:42:42 UTC) #1
Peter Beverloo
notifications lgtm % comment https://codereview.chromium.org/420103003/diff/1/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js File chrome/common/extensions/docs/examples/extensions/buildbot/bg.js (right): https://codereview.chromium.org/420103003/diff/1/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js#newcode34 chrome/common/extensions/docs/examples/extensions/buildbot/bg.js:34: lastNotification.show(); Line 34 should be ...
6 years, 5 months ago (2014-07-26 21:44:41 UTC) #2
tfarina
https://codereview.chromium.org/420103003/diff/1/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js File chrome/common/extensions/docs/examples/extensions/buildbot/bg.js (right): https://codereview.chromium.org/420103003/diff/1/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js#newcode34 chrome/common/extensions/docs/examples/extensions/buildbot/bg.js:34: lastNotification.show(); On 2014/07/26 21:44:41, Peter Beverloo wrote: > Line ...
6 years, 4 months ago (2014-07-27 01:34:18 UTC) #3
miket_OOO
LGTM and thanks!
6 years, 4 months ago (2014-07-28 14:34:55 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-29 02:09:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/420103003/20001
6 years, 4 months ago (2014-07-29 02:10:49 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 02:54:48 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 09:24:19 UTC) #8
Message was sent while issue was closed.
Change committed as 286141

Powered by Google App Engine
This is Rietveld 408576698