Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6173)

Unified Diff: chrome/common/extensions/docs/examples/extensions/buildbot/bg.js

Issue 420103003: Update Chromium Buildbot Monitor extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove show() call Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/docs/examples/extensions/buildbot/bg.js
diff --git a/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js b/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js
index a351678f1b3823ac7a26fe6a7986d308b6165c98..8324e03a1985b6536d75f63d84949962e27a4fcd 100644
--- a/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js
+++ b/chrome/common/extensions/docs/examples/extensions/buildbot/bg.js
@@ -25,12 +25,12 @@ function updateBadgeOnErrorStatus() {
var lastNotification = null;
function notifyStatusChange(treeState, status) {
if (lastNotification)
- lastNotification.cancel();
+ lastNotification.close();
- var notification = webkitNotifications.createNotification(
- chrome.extension.getURL("icon.png"), "Tree is " + treeState, status);
- lastNotification = notification;
- notification.show();
+ lastNotification = new Notification("Tree is " + treeState, {
+ icon: chrome.extension.getURL("icon.png"),
+ body: status
+ });
}
// The type parameter should be "open", "closed", or "throttled".
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698