Issue 419963005: Update clang warnings after r287092.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419963005: Update clang warnings after r287092. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
hans, wtc

CC:
chromium-reviews

Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/nss/

Project:
chromium_deps

Visibility:
Public.

More Reviews

Description

Update clang warnings after r287092. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287121

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -31 lines)			Patch
	M	nss.gyp	View		4 chunks	+22 lines, -31 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/419963005/1

6 years, 4 months ago (2014-08-01 23:50:15 UTC) #4

wtc

6 years, 4 months ago (2014-08-04 22:51:48 UTC) #6

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/419963005/diff/1/nss.gyp
File nss.gyp (right):

https://codereview.chromium.org/419963005/diff/1/nss.gyp#newcode250
nss.gyp:250: '-Wno-pointer-sign',

I'd be interested in fixing these warnings. I'll try to take a look.

https://codereview.chromium.org/419963005/diff/1/nss.gyp#newcode1070
nss.gyp:1070: '-Wno-tautological-compare',

Most of these should be fixed. I'll try to take a look.

Expand Messages | Collapse Messages