Update clang warnings after r287092.

nss.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'conditions': [
       ['OS=="ios"', {
         'exclude_nss_root_certs%': 0,
         'exclude_nss_libpkix%': 0,
@@ skipping 224 matching lines @@
           'NO_NSPR_10_SUPPORT',
         ],
         'include_dirs': [
           'nspr/pr/include',
           'nspr/lib/ds',
           'nspr/lib/libc/include',
         ],
       },
       # TODO(wtc): suppress C4244 and C4554 in prdtoa.c.
       'msvs_disabled_warnings': [4018, 4244, 4554, 4267,],
+      'variables': {
+        'clang_warning_flags': [
+          # nspr passes "const char*" through "void*".
+          '-Wno-incompatible-pointer-types',
+          # nspr passes "int*" through "unsigned int*".
+          '-Wno-pointer-sign',

[wtc, 2014/08/04 22:51:48]

I'd be interested in fixing these warnings. I'll try to take a look.

+        ],
+      },
       'conditions': [
         ['OS=="mac" or OS=="ios"', {
           'defines': [
             'XP_UNIX',
             'DARWIN',
             'XP_MACOSX',
             '_PR_PTHREADS',
             'HAVE_BSD_FLOCK',
             'HAVE_CRT_EXTERNS_H',
             'HAVE_DLADDR',
@@ skipping 64 matching lines @@
               'NSPR_STATIC',
             ],
           },
         }],
         ['clang==1', {
           'xcode_settings': {
             'WARNING_CFLAGS': [
               # nspr uses a bunch of deprecated functions (NSLinkModule etc) in
               # prlink.c on mac.
               '-Wno-deprecated-declarations',
-              # nspr passes "const char*" through "void*".
-              '-Wno-incompatible-pointer-types',
-              # nspr passes "int*" through "unsigned int*".
-              '-Wno-pointer-sign',
             ],
           },
-          'cflags': [
-            '-Wno-incompatible-pointer-types',
-            '-Wno-pointer-sign',
-          ],
         }],
       ],
     },
     {
       'target_name': 'nss',
       'product_name': 'crnss',
       'type': '<(component)',
       'dependencies': [
         'nss_static',
       ],
@@ skipping 700 matching lines @@
           'nss/lib/nss',
           'nss/lib/pk11wrap',
           'nss/lib/pkcs7',
           'nss/lib/pki',
           'nss/lib/smime',
           'nss/lib/softoken',
           'nss/lib/util',
         ],
       },
       'msvs_disabled_warnings': [4018, 4101, 4267, ],
+      'variables': {
+        'clang_warning_flags': [
+          # nss doesn't explicitly cast between different enum types.
+          '-Wno-conversion',
+          # nss passes "const char*" through "void*".
+          '-Wno-incompatible-pointer-types',
+          # nss prefers `a && b || c` over `(a && b) || c`.
+          '-Wno-logical-op-parentheses',
+          # nss doesn't use exhaustive switches on enums
+          '-Wno-switch',
+          # nss has some `unsigned < 0` checks.
+          '-Wno-tautological-compare',

[wtc, 2014/08/04 22:51:48]

Most of these should be fixed. I'll try to take a look.

+        ],
+      },
       'conditions': [
         ['exclude_nss_root_certs==1', {
           'defines': [
             'NSS_DISABLE_ROOT_CERTS',
           ],
         }],
         ['exclude_nss_libpkix==1', {
           'defines': [
             'NSS_DISABLE_LIBPKIX',
           ],
@@ skipping 136 matching lines @@
           'sources!': [
             'nss/lib/freebl/intel-aes-x64-masm.asm',
             'nss/lib/freebl/intel-aes-x86-masm.asm',
             'nss/lib/freebl/intel-gcm-wrap.c',
             'nss/lib/freebl/intel-gcm-x64-masm.asm',
             'nss/lib/freebl/intel-gcm-x86-masm.asm',
             # mpi_x86_asm.c contains MSVC inline assembly code.
             'nss/lib/freebl/mpi/mpi_x86_asm.c',
           ],
         }],
-        ['clang==1', {
-          'xcode_settings': {
-            'WARNING_CFLAGS': [
-              # nss doesn't explicitly cast between different enum types.
-              '-Wno-conversion',
-              # nss passes "const char*" through "void*".
-              '-Wno-incompatible-pointer-types',
-              # nss prefers `a && b || c` over `(a && b) || c`.
-              '-Wno-logical-op-parentheses',
-              # nss doesn't use exhaustive switches on enums
-              '-Wno-switch',
-              # nss has some `unsigned < 0` checks.
-              '-Wno-tautological-compare',
-            ],
-          },
-          'cflags': [
-            '-Wno-conversion',
-            '-Wno-incompatible-pointer-types',
-            '-Wno-logical-op-parentheses',
-            '-Wno-switch',
-            '-Wno-tautological-compare',
-          ],
-        }],
       ],
     },
   ],
 }