Issue 419943002: Revert of Move vertex buffer setup out of drawPackedGlyph().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419943002: Revert of Move vertex buffer setup out of drawPackedGlyph(). (Closed)

Created:
6 years, 5 months ago by jvanverth1

Modified:
6 years, 5 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Move vertex buffer setup out of drawPackedGlyph(). (https://codereview.chromium.org/414573002/) Reason for revert: Breaking Ubuntu and Windows bots. Original issue's description: > Move vertex buffer setup out of drawPackedGlyph(). > > This gets a very welcome ~10% speedup on my Mac. > > Committed: https://skia.googlesource.com/skia/+/1d38619389cc1100bd516b9acbf17b7bd42d33ce TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6c18c80c866dc1d89f0a76c93d62bbff886e3c2b

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+107 lines, -99 lines)			Patch
M	src/gpu/GrBitmapTextContext.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrBitmapTextContext.cpp	View	9 chunks	+55 lines, -51 lines	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/gpu/GrDistanceFieldTextContext.cpp	View	9 chunks	+49 lines, -47 lines	0 comments	Download

Total messages: 3 (0 generated)

jvanverth1

Created Revert of Move vertex buffer setup out of drawPackedGlyph().

6 years, 5 months ago (2014-07-25 18:51:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/419943002/1

6 years, 5 months ago (2014-07-25 18:52:12 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-25 18:52:29 UTC) #3

Message was sent while issue was closed.

Change committed as 6c18c80c866dc1d89f0a76c93d62bbff886e3c2b