Issue 419913003: Make content_shell link in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419913003: Make content_shell link in the GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make content_shell link in the GN build. It doesn't run yet. This disables WebRTC since that's not done yet. Libvpx isn't done either. This patch exports the disable flag for this from media to dependent targets like the GYP build does. It adds one extra check for this flag in Pepper. I assume everybody that compiles without libvpx also disables plugins so this has never come up before. Disable some warnings in Mesa. The resulting binary does not yet run. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285962

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove the if #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Android spelling #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -73 lines)			Patch
M	build/config/features.gni	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	build/secondary/third_party/icu/BUILD.gn	View	1 2 3 4	2 chunks	+12 lines, -2 lines	0 comments	Download
M	content/BUILD.gn	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	content/app/BUILD.gn	View		1 chunk	+103 lines, -49 lines	0 comments	Download
M	content/content.gyp	View		10 chunks	+18 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/video_decoder_shim.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	content/shell/BUILD.gn	View	1 2	6 chunks	+4 lines, -10 lines	0 comments	Download
M	media/BUILD.gn	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	third_party/mesa/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Requires https://codereview.chromium.org/422533005/ to land first.

6 years, 5 months ago (2014-07-25 18:09:43 UTC) #1

jamesr

lgtm https://codereview.chromium.org/419913003/diff/1/content/shell/BUILD.gn File content/shell/BUILD.gn (right): https://codereview.chromium.org/419913003/diff/1/content/shell/BUILD.gn#newcode421 content/shell/BUILD.gn:421: if (true) { # TODO(GYP) enable once this ...

6 years, 5 months ago (2014-07-25 18:16:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #5 manually as r285962.

Expand Messages | Collapse Messages