Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: build/secondary/third_party/icu/BUILD.gn

Issue 419913003: Make content_shell link in the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android spelling Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/config/features.gni ('k') | content/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Tells icu to load an external data file rather than rely on the icudata 6 # Tells icu to load an external data file rather than rely on the icudata
7 # being linked directly into the binary. 7 # being linked directly into the binary.
8 icu_use_data_file = false 8 #
9 # This flag is a bit confusing. As of this writing, icu.gyp set the value to
10 # 0 but common.gypi sets the value to 1 for most platforms (and the 1 takes
11 # precedence).
12 #
13 # TODO(GYP) We'll probably need to enhance this logic to set the value to
14 # true or false in similar circumstances. Note that in the GYP build, some
15 # other projects access this variable. If we need to do a similar thing,
16 # we should probably make an icu config file (//third_party/icu/config.gni)
17 # with this flag in it rather than making it global.
18 icu_use_data_file = true
9 } 19 }
10 20
11 # Meta target that includes both icuuc and icui18n. Most targets want both. 21 # Meta target that includes both icuuc and icui18n. Most targets want both.
12 # You can depend on the individually if you need to. 22 # You can depend on the individually if you need to.
13 group("icu") { 23 group("icu") {
14 deps = [ 24 deps = [
15 ":icui18n", 25 ":icui18n",
16 ":icuuc", 26 ":icuuc",
17 ] 27 ]
18 } 28 }
(...skipping 444 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 if (is_ios) { 473 if (is_ios) {
464 # TODO(GYP): Support mac resource bundle shown below. 474 # TODO(GYP): Support mac resource bundle shown below.
465 # 'link_settings': { 475 # 'link_settings': {
466 # 'mac_bundle_resources': [ 476 # 'mac_bundle_resources': [
467 # 'source/data/in/icudtl.dat', 477 # 'source/data/in/icudtl.dat',
468 # ], 478 # ],
469 # } 479 # }
470 } else { 480 } else {
471 copy("icudata") { 481 copy("icudata") {
472 if (is_android) { 482 if (is_android) {
473 sources = [ "android/icudt.dat" ] 483 sources = [ "android/icudtl.dat" ]
474 } else { 484 } else {
475 sources = [ "source/data/in/icudtl.dat" ] 485 sources = [ "source/data/in/icudtl.dat" ]
476 } 486 }
477 487
478 outputs = [ "$root_out_dir/icudtl.dat" ] 488 outputs = [ "$root_out_dir/icudtl.dat" ]
479 } 489 }
480 } 490 }
481 } else { 491 } else {
482 if (is_win) { 492 if (is_win) {
483 # On Windows the target DLL is pre-built so just use a copy rule. 493 # On Windows the target DLL is pre-built so just use a copy rule.
(...skipping 13 matching lines...) Expand all
497 sources = [ "mac/icudtl_dat.S" ] 507 sources = [ "mac/icudtl_dat.S" ]
498 } else if (is_android) { 508 } else if (is_android) {
499 sources = [ "android/icudtl_dat.S" ] 509 sources = [ "android/icudtl_dat.S" ]
500 } else { 510 } else {
501 assert(false, "No icu data for this platform") 511 assert(false, "No icu data for this platform")
502 } 512 }
503 defines = [ "U_HIDE_DATA_SYMBOL" ] 513 defines = [ "U_HIDE_DATA_SYMBOL" ]
504 } 514 }
505 } 515 }
506 } 516 }
OLDNEW
« no previous file with comments | « build/config/features.gni ('k') | content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698