Source/core/loader/FrameLoader.h - Issue 419863004: Refactor frame detach to work for both local and remote frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.h

Issue 419863004: Refactor frame detach to work for both local and remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix comment typo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.h

diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h

index 3df3520b8145a0a04893e6c219208768b34d6402..7ba046b26648126abfc68ecf17e1e31680b39edb 100644

--- a/Source/core/loader/FrameLoader.h

+++ b/Source/core/loader/FrameLoader.h

@@ -158,7 +158,7 @@ public:

LocalFrame* opener();

void setOpener(LocalFrame*);

- void frameDetached();

+ void detachFromParent();

void loadDone();

void finishedParsing();

@@ -216,8 +216,6 @@ private:

bool validateTransitionNavigationMode();

bool dispatchNavigationTransitionData();

- void detachFromParent();

- void detachChildren();

void detachClient();

void setHistoryItemStateForCommit(HistoryCommitType, bool isPushOrReplaceState = false, PassRefPtr<SerializedScriptValue> = nullptr);

« no previous file with comments | « Source/core/html/HTMLFrameOwnerElement.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »