Source/core/html/HTMLFrameOwnerElement.cpp - Issue 419863004: Refactor frame detach to work for both local and remote frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFrameOwnerElement.cpp

Issue 419863004: Refactor frame detach to work for both local and remote frames. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix comment typo Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/Source/core/html/HTMLFrameOwnerElement.cpp b/Source/core/html/HTMLFrameOwnerElement.cpp

index 9ac66b9116f5ddd21371b7479e87a5d8981b9a6c..02986c5c9d6e992abbcdf3407dacf63f6d93cb63 100644

--- a/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -144,8 +144,7 @@ void HTMLFrameOwnerElement::disconnectContentFrame()

// see if this behavior is really needed as Gecko does not allow this.

if (Frame* frame = contentFrame()) {

RefPtr<Frame> protect(frame);

- if (frame->isLocalFrame())

- toLocalFrame(frame)->loader().frameDetached();

+ frame->detach();

frame->disconnectOwnerElement();

}

« no previous file with comments | « Source/core/frame/RemoteFrame.cpp ('k') | Source/core/loader/FrameLoader.h » ('j') | no next file with comments »