Issue 419853002: Add explicit destructor to DatabaseBackend.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419853002: Add explicit destructor to DatabaseBackend.h. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
michaeln, Reid Kleckner

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Add explicit destructor to DatabaseBackend.h. This class was missed in https://codereview.chromium.org/412483007/, see that CL's description for the motivation. I filed http://llvm.org/20452 about the diagnostic for this not being as clear as it could be. BUG=82385 R=rnk@chromium.org TBR=michaeln Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178945

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	Source/modules/webdatabase/DatabaseBackend.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/modules/webdatabase/DatabaseBackend.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Nico

6 years, 5 months ago (2014-07-25 18:03:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r178945 (presubmit successful).