Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: Source/modules/webdatabase/DatabaseBackend.h

Issue 419853002: Add explicit destructor to DatabaseBackend.h. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/modules/webdatabase/DatabaseBackend.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 // FIXME: This implementation of DatabaseBackend is only a place holder 43 // FIXME: This implementation of DatabaseBackend is only a place holder
44 // for the split out of the Database backend to be done later. This 44 // for the split out of the Database backend to be done later. This
45 // place holder is needed to allow other code that need to reference the 45 // place holder is needed to allow other code that need to reference the
46 // DatabaseBackend to do so before the proper backend split is 46 // DatabaseBackend to do so before the proper backend split is
47 // available. This should be replaced with the actual implementation later. 47 // available. This should be replaced with the actual implementation later.
48 48
49 class DatabaseBackend : public DatabaseBackendBase { 49 class DatabaseBackend : public DatabaseBackendBase {
50 public: 50 public:
51 DatabaseBackend(DatabaseContext*, const String& name, const String& expected Version, const String& displayName, unsigned long estimatedSize); 51 DatabaseBackend(DatabaseContext*, const String& name, const String& expected Version, const String& displayName, unsigned long estimatedSize);
52 virtual ~DatabaseBackend();
52 virtual void trace(Visitor*) OVERRIDE; 53 virtual void trace(Visitor*) OVERRIDE;
53 54
54 virtual bool openAndVerifyVersion(bool setVersionInNewDatabase, DatabaseErro r&, String& errorMessage) OVERRIDE FINAL; 55 virtual bool openAndVerifyVersion(bool setVersionInNewDatabase, DatabaseErro r&, String& errorMessage) OVERRIDE FINAL;
55 void close(); 56 void close();
56 57
57 PassRefPtrWillBeRawPtr<SQLTransactionBackend> runTransaction(PassRefPtrWillB eRawPtr<SQLTransaction>, bool readOnly, const ChangeVersionData*); 58 PassRefPtrWillBeRawPtr<SQLTransactionBackend> runTransaction(PassRefPtrWillB eRawPtr<SQLTransaction>, bool readOnly, const ChangeVersionData*);
58 void scheduleTransactionStep(SQLTransactionBackend*); 59 void scheduleTransactionStep(SQLTransactionBackend*);
59 void inProgressTransactionCompleted(); 60 void inProgressTransactionCompleted();
60 61
61 SQLTransactionClient* transactionClient() const; 62 SQLTransactionClient* transactionClient() const;
(...skipping 13 matching lines...) Expand all
75 Mutex m_transactionInProgressMutex; 76 Mutex m_transactionInProgressMutex;
76 bool m_transactionInProgress; 77 bool m_transactionInProgress;
77 bool m_isTransactionQueueEnabled; 78 bool m_isTransactionQueueEnabled;
78 79
79 friend class Database; 80 friend class Database;
80 }; 81 };
81 82
82 } // namespace blink 83 } // namespace blink
83 84
84 #endif // DatabaseBackend_h 85 #endif // DatabaseBackend_h
OLDNEW
« no previous file with comments | « no previous file | Source/modules/webdatabase/DatabaseBackend.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698