Issue 419803005: PNaCl documentation: clarify vector alignment, and update navigation

Issue 419803005: PNaCl documentation: clarify vector alignment, and update navigation (Closed)

Created:
6 years, 5 months ago by JF

Modified:
6 years, 4 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

PNaCl documentation: clarify vector alignment, and update navigation R= binji@chromium.org TEST=none BUG=none NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285923

Patch Set 2 : Revert weird edit. #

Total comments: 4

Patch Set 3 : Fixes. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -22 lines)			Patch
M	chrome/common/extensions/docs/templates/json/chrome_sidenav.json	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html	View	1 2	3 chunks	+23 lines, -5 lines	0 comments	Download
M	native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst	View	1 2	2 chunks	+30 lines, -17 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

https://codereview.chromium.org/419803005/diff/1/native_client_sdk/doc_generated/community/index.html File native_client_sdk/doc_generated/community/index.html (right): https://codereview.chromium.org/419803005/diff/1/native_client_sdk/doc_generated/community/index.html#newcode6 native_client_sdk/doc_generated/community/index.html:6: <strong>implementors</strong> (contributors to the <a class="reference external" href="nacl_project_">open-source Native ...

6 years, 5 months ago (2014-07-26 00:12:09 UTC) #2

binji

lgtm https://codereview.chromium.org/419803005/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst File native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst (right): https://codereview.chromium.org/419803005/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst#newcode219 native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst:219: and more features, including performance enhancements, have been ...

6 years, 5 months ago (2014-07-26 00:24:08 UTC) #3

I edited a few more things. https://codereview.chromium.org/419803005/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst File native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst (right): https://codereview.chromium.org/419803005/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst#newcode219 native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst:219: and more features, ...

6 years, 4 months ago (2014-07-28 16:36:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/419803005/40001

6 years, 4 months ago (2014-07-28 16:37:51 UTC) #6

Message was sent while issue was closed.

Change committed as 285923

Expand Messages | Collapse Messages