Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 419773006: Revert of Blink roll 178929:178950 (Closed)

Created:
6 years, 5 months ago by Mark P
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Blink roll 178929:178950 (https://codereview.chromium.org/417293002/) Reason for revert: Causes a slew of devtools failures: 17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.6%20Tests%20(1) [17:18] <mpearson> http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac10.7%20Tests%20(1) [17:19] <mpearson> http://build.chromium.org/p/chromium.chromiumos/waterfall?builder=Linux%20ChromiumOS%20Ozone%20Tests%20(2) [17:19] == tapted_ [~tapted@121.211.79.93] has quit [Quit: tapted_] [17:19] <mpearson> http://build.chromium.org/p/chromium.win/waterfall?builder=Vista%20Tests%20(1) failed 4 stdio TestConsoleOnNavigateBack TestDeviceEmulation TestNetworkSyncSize TestScriptsTabIsPopulatedOnInspectedPageRefresh browser_tests browser_tests 544 disabled 5 flaky failed 4 stdio TestDevToolsExtensionAPI TestNetworkRawHeadersText TestToolboxNotLoadedDocked RemoteDebugger stdio TestDevToolsOnDevTools TestDevToolsExperimentalExtensionAPI TestDevToolsExtensionAPI TestDevToolsExtensionMessaging TestConsoleOnNavigateBack TestDeviceEmulation TestNetworkRawHeadersText TestNetworkSize TestNetworkSyncSize TestNetworkTiming TestPauseWhenScriptIsRunning TestScriptsTabIsPopulatedOnInspectedPageRefresh TestToolboxNotLoadedDocked RemoteDebugger InspectSharedWorker Original issue's description: > Blink roll 178929:178950 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178950&mode=html > TBR=haraken@chromium.org,jchaffraix@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285699 TBR=haraken@chromium.org,jchaffraix@chromium.org,eseidel@chromium.org,blink-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
Created Revert of Blink roll 178929:178950
6 years, 5 months ago (2014-07-26 00:25:33 UTC) #1
Mark P
The CQ bit was unchecked by mpearson@chromium.org
6 years, 5 months ago (2014-07-26 00:58:51 UTC) #2
Mark P
On 2014/07/26 00:58:51, Mark P wrote: > The CQ bit was unchecked by mailto:mpearson@chromium.org The ...
6 years, 5 months ago (2014-07-26 00:59:18 UTC) #3
Julien - ping for review
6 years, 5 months ago (2014-07-26 02:26:03 UTC) #4
Message was sent while issue was closed.
On 2014/07/26 00:59:18, Mark P wrote:
> On 2014/07/26 00:58:51, Mark P wrote:
> > The CQ bit was unchecked by mailto:mpearson@chromium.org
> 
> The CQ apparently didn't pick up this revert and apply it.
> 
> Instead, I reverted with drover.  Silly me to trust the newfangled revert
> patchset button.
> 
> --mark

FYI the revert is wrong. All linked dashboards have recovered before the revert
but we missed it.

We were wrongly led to believe that it was the Blink roll due to a to a commit /
revert that wasn't reported to gardener / sheriff that caused a transient
failure on most bots (thinking about
http://src.chromium.org/viewvc/chrome?revision=285713&view=revision).

Powered by Google App Engine
This is Rietveld 408576698