Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 419713002: Support permission_broker for chrome.hid devices. (Closed)

Created:
6 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 4 months ago
CC:
Reilly Grant (use Gerrit), chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tapted
Project:
chromium
Visibility:
Public.

Description

Support permission_broker for chrome.hid devices. This enables the Chrome to query permission_broker for access to hidraw device paths when running on Chrome OS. HidService has been refactored so that it is owned by the extensions API embedder, rather than being a singleton. Because hid has just moved to //extensions as well, this also establishes a new ShellExtensionsAPIClient to create a HidService for app_shell. BUG=367145 TEST=manual test on ChromeOS dev build TBR=derat@chromium.org for mechanical app_shell changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285774

Patch Set 1 #

Patch Set 2 : Fix ChromeOS code #

Patch Set 3 : Add NOTIMPLEMENTED to default GetHidService implementation. #

Total comments: 1

Patch Set 4 : Unobliterate whitespace, restore order to the universe #

Patch Set 5 : Fix mac build #

Patch Set 6 : Add chromeos/dbus to device/hid DEPS #

Patch Set 7 : adfoiajsdfoaisjdfasdf #

Patch Set 8 : Ooops, tests #

Patch Set 9 : Fix hid in app_shell after its move to //extensions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -102 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -2 lines 0 comments Download
M device/hid/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_connection_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_connection_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service.h View 3 chunks +6 lines, -12 lines 0 comments Download
M device/hid/hid_service.cc View 3 chunks +15 lines, -35 lines 0 comments Download
M device/hid/hid_service_linux.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M device/hid/hid_service_linux.cc View 1 5 chunks +62 lines, -22 lines 0 comments Download
M device/hid/hid_service_mac.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_service_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 1 2 3 4 5 6 7 8 4 chunks +4 lines, -3 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 2 3 4 5 6 7 8 1 chunk +14 lines, -0 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/extensions_strings.grd View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -1 line 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/browser/DEPS View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_extensions_api_client.h View 1 2 3 4 5 6 7 8 1 chunk +28 lines, -0 lines 0 comments Download
A extensions/shell/browser/api/shell_extensions_api_client.cc View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ken Rockot(use gerrit already)
Renaud, could you please take a look?
6 years, 5 months ago (2014-07-25 18:45:36 UTC) #1
rpaquay
lgtm
6 years, 5 months ago (2014-07-25 19:51:41 UTC) #2
Ken Rockot(use gerrit already)
+reillyg@ FYI
6 years, 5 months ago (2014-07-25 19:52:49 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 5 months ago (2014-07-25 19:52:53 UTC) #4
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/419713002/diff/40001/chrome/browser/extensions/api/hid/hid_device_manager.cc File chrome/browser/extensions/api/hid/hid_device_manager.cc (left): https://codereview.chromium.org/419713002/diff/40001/chrome/browser/extensions/api/hid/hid_device_manager.cc#oldcode6 chrome/browser/extensions/api/hid/hid_device_manager.cc:6: Leave this whitespace.
6 years, 5 months ago (2014-07-25 19:57:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/419713002/40001
6 years, 5 months ago (2014-07-25 19:57:45 UTC) #6
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 5 months ago (2014-07-25 20:02:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/419713002/60001
6 years, 5 months ago (2014-07-25 20:04:09 UTC) #8
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 5 months ago (2014-07-26 00:17:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/419713002/150001
6 years, 5 months ago (2014-07-26 05:00:15 UTC) #10
commit-bot: I haz the power
Change committed as 285774
6 years, 5 months ago (2014-07-26 18:25:43 UTC) #11
tapted
6 years, 4 months ago (2014-07-28 00:04:50 UTC) #12
Message was sent while issue was closed.
On 2014/07/26 18:25:43, I haz the power (commit-bot) wrote:
> Change committed as 285774

Lnux ASan LSan Tests (1) is detecting a memory leak since
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

errors like

Direct leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x44145b in operator new(unsigned long)
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x5e8afd in
device::HidService::Create(scoped_refptr\u003Cbase::MessageLoopProxy>)
device/hid/hid_service.cc:26
    #2 0x509324 in device::HidServiceTest_Create_Test::TestBody()
device/hid/hid_service_unittest.cc:15

Looks like a simple fix - https://codereview.chromium.org/424623002/ is in the
CQ.

Powered by Google App Engine
This is Rietveld 408576698