Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2433)

Unified Diff: device/hid/hid_service.cc

Issue 419713002: Support permission_broker for chrome.hid devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix hid in app_shell after its move to //extensions Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/hid/hid_service.h ('k') | device/hid/hid_service_linux.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_service.cc
diff --git a/device/hid/hid_service.cc b/device/hid/hid_service.cc
index 8aa7cd4a37755d0b618b233704d9b60a1dee9795..0e2f0d4c7716b4cda9ac777657487bb1204cc15f 100644
--- a/device/hid/hid_service.cc
+++ b/device/hid/hid_service.cc
@@ -20,13 +20,22 @@
namespace device {
-namespace {
-
-// The instance will be reset when message loop destroys.
-base::LazyInstance<scoped_ptr<HidService> >::Leaky g_hid_service_ptr =
- LAZY_INSTANCE_INITIALIZER;
+HidService* HidService::Create(
+ scoped_refptr<base::MessageLoopProxy> ui_message_loop) {
+#if defined(OS_LINUX) && defined(USE_UDEV)
+ return new HidServiceLinux(ui_message_loop);
+#elif defined(OS_MACOSX)
+ return new HidServiceMac();
+#elif defined(OS_WIN)
+ return new HidServiceWin();
+#else
+ return NULL;
+#endif
+}
-} // namespace
+HidService::~HidService() {
+ DCHECK(thread_checker_.CalledOnValidThread());
+}
void HidService::GetDevices(std::vector<HidDeviceInfo>* devices) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -48,32 +57,9 @@ bool HidService::GetDeviceInfo(const HidDeviceId& device_id,
return true;
}
-void HidService::WillDestroyCurrentMessageLoop() {
- DCHECK(thread_checker_.CalledOnValidThread());
- g_hid_service_ptr.Get().reset(NULL);
-}
-
HidService::HidService() {
base::ThreadRestrictions::AssertIOAllowed();
DCHECK(thread_checker_.CalledOnValidThread());
- base::MessageLoop::current()->AddDestructionObserver(this);
-}
-
-HidService::~HidService() {
- DCHECK(thread_checker_.CalledOnValidThread());
- base::MessageLoop::current()->RemoveDestructionObserver(this);
-}
-
-HidService* HidService::CreateInstance() {
-#if defined(OS_LINUX) && defined(USE_UDEV)
- return new HidServiceLinux();
-#elif defined(OS_MACOSX)
- return new HidServiceMac();
-#elif defined(OS_WIN)
- return new HidServiceWin();
-#else
- return NULL;
-#endif
}
void HidService::AddDevice(const HidDeviceInfo& info) {
@@ -94,10 +80,4 @@ const HidService::DeviceMap& HidService::GetDevicesNoEnumerate() const {
return devices_;
}
-HidService* HidService::GetInstance() {
- if (!g_hid_service_ptr.Get().get())
- g_hid_service_ptr.Get().reset(CreateInstance());
- return g_hid_service_ptr.Get().get();
-}
-
} // namespace device
« no previous file with comments | « device/hid/hid_service.h ('k') | device/hid/hid_service_linux.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698