Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 419643008: Make Screen Orientation use Platform Events in order to handle polling. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@platform_events
Project:
blink
Visibility:
Public.

Description

Make Screen Orientation us Platform Events in order to handle polling. BUG=162827 NOTRY=True Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179620

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -4 lines) Patch
M Source/modules/modules.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 2 5 chunks +33 lines, -1 line 0 comments Download
A Source/modules/screen_orientation/ScreenOrientationDispatcher.h View 1 chunk +39 lines, -0 lines 0 comments Download
A Source/modules/screen_orientation/ScreenOrientationDispatcher.cpp View 1 chunk +36 lines, -0 lines 0 comments Download
M public/platform/Platform.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebPlatformEventType.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-07-29 13:49:57 UTC) #1
mlamouri (slow - plz ping)
Review ping. Adam, could you have a look at this CL. It follows https://codereview.chromium.org/417213002/ As ...
6 years, 4 months ago (2014-08-01 10:22:27 UTC) #2
abarth-chromium
LGTM It's not clear to me whether we're calling notifyDispatcher() in exactly the right places, ...
6 years, 4 months ago (2014-08-01 17:57:10 UTC) #3
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-06 10:54:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/419643008/40001
6 years, 4 months ago (2014-08-06 10:56:11 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 14:05:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 14:29:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/20073)
6 years, 4 months ago (2014-08-06 14:29:03 UTC) #8
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-06 14:44:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/419643008/40001
6 years, 4 months ago (2014-08-06 14:45:07 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 15:19:54 UTC) #11
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-06 15:30:40 UTC) #12
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-06 15:30:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/419643008/40001
6 years, 4 months ago (2014-08-06 15:30:52 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 15:31:54 UTC) #15
Message was sent while issue was closed.
Change committed as 179620

Powered by Google App Engine
This is Rietveld 408576698