Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 419623002: Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
picksi, Dominik Grewe, Sami
CC:
chromium-reviews, telemetry+watch_chromium.org, picksi1, oystein (OOO til 10th of July)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (https://codereview.chromium.org/392613002/) Reason for revert: Breaks smoothness tests on N4 (at least) with no frames error. Possible this is a legit perf regression? But reverting anyway to green things up. http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1115 Original issue's description: > Telemetry: Initialize smoothness and thread_times metrics before page load, not after. > > Currently both smoothness and thread_times initialize their metrics after page > load. This leads to a gap between the page load and the page actions starting. > This patch moves the initialization before the page load, thus eliminating the > gap. It is safe to do so because smoothness and thread_times require a page load > before each run (even when repeating the same page). > > Note to perf sheriffs: > This patch is likely to cause performance numbers to worsen, because the browser is often more busy immediately after page load. If you get alerts related to this CL, feel free to ignore them. If there is a reference build for the bot, the number for the reference build should also change accordingly. > > BUG=392895 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285297 TBR=skyostil@chromium.org,picksi@google.com,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG=392895 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M tools/perf/measurements/loading_trace.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/repaint.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/perf/measurements/smoothness_controller.py View 2 chunks +1 line, -3 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/measurements/thread_times.py View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after.
6 years, 5 months ago (2014-07-24 22:34:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/419623002/1
6 years, 5 months ago (2014-07-24 22:36:01 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 22:38:34 UTC) #3
Message was sent while issue was closed.
Change committed as 285395

Powered by Google App Engine
This is Rietveld 408576698