tools/perf/measurements/smoothness_controller.py - Issue 419623002: Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness_controller.py

Issue 419623002: Revert of Telemetry: Initialize smoothness and thread_times metrics before page load, not after. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness_controller.py

diff --git a/tools/perf/measurements/smoothness_controller.py b/tools/perf/measurements/smoothness_controller.py

index 6e8dcd9acead0a809ee674bad59ede024a9cec59..c054ccc6e2b03b8639ec7e7937175fbabdc4734e 100644

--- a/tools/perf/measurements/smoothness_controller.py

+++ b/tools/perf/measurements/smoothness_controller.py

@@ -27,7 +27,7 @@

self._tracing_timeline_data = None

self._interaction = None

- def SetUp(self, page, tab):

+ def Start(self, page, tab):

# FIXME: Remove webkit.console when blink.console lands in chromium and

# the ref builds are updated. crbug.com/386847

custom_categories = ['webkit.console', 'blink.console', 'benchmark']

@@ -35,8 +35,6 @@

tab.browser.StartTracing(','.join(custom_categories), 60)

if tab.browser.platform.IsRawDisplayFrameRateSupported():

tab.browser.platform.StartRawDisplayFrameRateMeasurement()

- def Start(self, tab):

# Start the smooth marker for all smooth actions.

runner = action_runner.ActionRunner(tab)

self._interaction = runner.BeginInteraction(

« no previous file with comments | « tools/perf/measurements/smoothness.py ('k') | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »