Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 419433002: Correct ownership of mojo OmniboxUIHandler (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, James Su, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Correct ownership of mojo OmniboxUIHandler This object is owned by the MojoWebUIController, not bound to the pipe. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/webui/omnibox/omnibox_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
Followup to r285139. I'm a bit baffled that this made it through the CQ...
6 years, 5 months ago (2014-07-24 06:07:47 UTC) #1
jamesr
Committed patchset #1 manually as r285156 (tree was closed).
6 years, 5 months ago (2014-07-24 06:08:10 UTC) #2
jamesr
Ahhh, this landed because the trybots don't do real debug builds, they do release-with-dchecks but ...
6 years, 5 months ago (2014-07-24 06:09:05 UTC) #3
sky
6 years, 5 months ago (2014-07-24 16:48:53 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698