chrome/browser/ui/webui/omnibox/omnibox_ui.cc - Issue 419433002: Correct ownership of mojo OmniboxUIHandler

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Issue 419433002: Correct ownership of mojo OmniboxUIHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/omnibox/omnibox_ui.h"	5 #include "chrome/browser/ui/webui/omnibox/omnibox_ui.h"

6	6

7 #include "chrome/browser/profiles/profile.h"	7 #include "chrome/browser/profiles/profile.h"

8 #include "chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h"	8 #include "chrome/browser/ui/webui/omnibox/omnibox_ui_handler.h"

9 #include "chrome/common/url_constants.h"	9 #include "chrome/common/url_constants.h"

10 #include "content/public/browser/web_ui.h"	10 #include "content/public/browser/web_ui.h"

(...skipping 13 matching lines...) Expand all Loading...
24	24

25 AddMojoResourcePath("chrome/browser/ui/webui/omnibox/omnibox.mojom",	25 AddMojoResourcePath("chrome/browser/ui/webui/omnibox/omnibox.mojom",

26 IDR_OMNIBOX_MOJO_JS);	26 IDR_OMNIBOX_MOJO_JS);

27 }	27 }

28	28

29 OmniboxUI::~OmniboxUI() {}	29 OmniboxUI::~OmniboxUI() {}

30	30

31 scoped_ptr<MojoWebUIHandler> OmniboxUI::CreateUIHandler(	31 scoped_ptr<MojoWebUIHandler> OmniboxUI::CreateUIHandler(

32 mojo::ScopedMessagePipeHandle handle_to_page) {	32 mojo::ScopedMessagePipeHandle handle_to_page) {

33 return scoped_ptr<MojoWebUIHandler>(	33 return scoped_ptr<MojoWebUIHandler>(

34 mojo::BindToPipe(new OmniboxUIHandler(Profile::FromWebUI(web_ui())),	34 mojo::WeakBindToPipe(new OmniboxUIHandler(Profile::FromWebUI(web_ui())),

35 handle_to_page.Pass()));	35 handle_to_page.Pass()));

36 }	36 }

OLD	NEW