Issue 419423004: Revert 285867 "Revert 285832 "Disable accessible touch explorati..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419423004: Revert 285867 "Revert 285832 "Disable accessible touch explorati..." (Closed)

Created:
6 years, 4 months ago by hajimehoshi

Modified:
6 years, 4 months ago

Reviewers:
dmazzoni at google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 285867 "Revert 285832 "Disable accessible touch explorati..." > Revert 285832 "Disable accessible touch exploration by default." > > This change was to disable the feature on M37. Reverting so that > accessible touch exploration is enabled again on trunk. > > > Disable accessible touch exploration by default. > > > > Touch exploration was too buggy in M37, we don't want to launch it. > > The plan is to land this change and merge to M37, then revert it to aim for > > a launch of touch exploration in M38. > > > > BUG=396193 > > > > Review URL: https://codereview.chromium.org/414493004 > > TBR=dmazzoni@chromium.org > > Review URL: https://codereview.chromium.org/419423003 TBR=dmazzoni@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285871

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -9 lines)			Patch
M	trunk/src/ash/ash_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/ash_switches.cc	View	1 chunk	+5 lines, -6 lines	0 comments	Download
M	trunk/src/ash/root_window_controller.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hajimehoshi

Committed patchset #1 manually as r285871 (tree was closed).

6 years, 4 months ago (2014-07-28 06:54:35 UTC) #2

dmazzoni

6 years, 4 months ago (2014-07-28 07:03:36 UTC) #3

Message was sent while issue was closed.

On 2014/07/28 06:54:35, hajimehoshi wrote:
> Committed patchset #1 manually as r285871 (tree was closed).

I don't think this was related to the tree failure.

Expand Messages | Collapse Messages