Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 414493004: Disable accessible touch exploration by default. (Closed)

Created:
6 years, 5 months ago by dmazzoni
Modified:
6 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, evy, lisayin, aboxhall
Project:
chromium
Visibility:
Public.

Description

Disable accessible touch exploration by default. Touch exploration was too buggy in M37, we don't want to launch it. The plan is to land this change and merge to M37, then revert it to aim for a launch of touch exploration in M38. BUG=396193 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285832

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Set flag in browser tests that depend on it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M ash/ash_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M ash/root_window_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
dmazzoni
6 years, 5 months ago (2014-07-22 19:24:12 UTC) #1
James Cook
LGTM Out of curiosity (and probably not for this CL) does this flag need to ...
6 years, 5 months ago (2014-07-22 19:38:17 UTC) #2
dmazzoni
Thanks, I'll look into OTR.
6 years, 5 months ago (2014-07-22 19:46:36 UTC) #3
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-24 06:49:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/414493004/1
6 years, 5 months ago (2014-07-24 06:52:07 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 07:05:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 07:08:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/173260) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/162291) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-24 07:08:10 UTC) #8
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-24 08:19:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/414493004/20001
6 years, 5 months ago (2014-07-24 08:21:55 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 10:15:29 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 11:29:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/50877)
6 years, 5 months ago (2014-07-24 11:29:35 UTC) #13
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-24 18:26:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/414493004/40001
6 years, 5 months ago (2014-07-24 18:28:31 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:03:29 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:35:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2130)
6 years, 5 months ago (2014-07-24 22:35:42 UTC) #18
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-25 06:17:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/414493004/40001
6 years, 5 months ago (2014-07-25 06:17:36 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 07:24:00 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 07:59:04 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2306)
6 years, 5 months ago (2014-07-25 07:59:05 UTC) #23
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 5 months ago (2014-07-26 21:46:21 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/414493004/40001
6 years, 5 months ago (2014-07-26 21:46:56 UTC) #25
commit-bot: I haz the power
6 years, 5 months ago (2014-07-27 11:20:42 UTC) #26
Message was sent while issue was closed.
Change committed as 285832

Powered by Google App Engine
This is Rietveld 408576698