clang/win: Fix a few warnings.

media/audio/win/audio_device_listener_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/win/audio_device_listener_win.h"
 
 #include <Audioclient.h>
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 128 matching lines @@
     EDataFlow flow, ERole role, LPCWSTR new_default_device_id) {
   // Only listen for console and communication device changes.
   if ((role != eConsole && role != eCommunications) ||
       (flow != eRender && flow != eCapture)) {
     return S_OK;
   }
 
   // Grab a pointer to the appropriate ID member.
   // Note that there are three "?:"'s here to select the right ID.
   std::string* current_device_id =
-      role == eRender ? (
-          flow == eConsole ?
+      role == eConsole ? (

[tommi (sloooow) - chröme, 2014/07/28 22:48:38]

ehm, thanks for fixing this. Sadly (mea culpa) I'm not sure it's correct still.
I think this should be:

flow == eRender ? (
    role == eConsole ? (
        &default_render_device_id_ :
        &default_communications_render_device_id_
    ) : (
        role == eConsole ? (
            &default_capture_device_id_ :
            &default_communications_capture_device_id_
    );

Basically the |role| and |flow| variables were mixed up, not the constants :(

+          flow == eRender ?
               &default_render_device_id_ :
               &default_communications_render_device_id_
       ) : (
-          flow == eConsole ?
+          flow == eRender ?
               &default_capture_device_id_ :
               &default_communications_capture_device_id_
       );
 
   // If no device is now available, |new_default_device_id| will be NULL.
   std::string new_device_id;
   if (new_default_device_id)
     new_device_id = base::WideToUTF8(new_default_device_id);
 
   VLOG(1) << "OnDefaultDeviceChanged() "
@@ skipping 11 matching lines @@
     return S_OK;
 
   // Store the new id in the member variable (that current_device_id points to).
   *current_device_id = new_device_id;
   listener_cb_.Run();
 
   return S_OK;
 }
 
 }  // namespace media