clang/win: Fix a few warnings.

clang/win: Fix a few warnings.

__THROW is not some magical thing, don't pretend it is. Don't add it to
extern "C" functions. Replace it with "throw ()" on the functions where it's
correct since it was defined to nothing on windows (the only place where this
file is used).

Fix an inconsequential enum constant mix-up in media (both enum constants
evaluated to the same value, and the enums had the same size, so it shouldn't
make a difference in practice, but the old code was comparing enum variables
with enum constants from a different enum).

BUG=82385
TBR=dalecurtis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285838

[Nico, 2014-07-26 20:21:42]

willchan: base/ (when are you going to take allocator_shim behind the barn? :-)
)
dalecurtis: media

[willchan no longer on Chromium, 2014-07-27 03:34:42]

lgtm

[Nico, 2014-07-27 04:37:29]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-07-27 04:38:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thakis@chromium.org/419323002/1

[commit-bot: I haz the power, 2014-07-27 11:30:47]

Change committed as 285838

[DaleCurtis, 2014-07-28 18:57:56]

lgtm

[tommi (sloooow) - chröme, 2014-07-28 22:48:38]

https://codereview.chromium.org/419323002/diff/1/media/audio/win/audio_device...
File media/audio/win/audio_device_listener_win.cc (right):

https://codereview.chromium.org/419323002/diff/1/media/audio/win/audio_device...
media/audio/win/audio_device_listener_win.cc:149: role == eConsole ? (
ehm, thanks for fixing this. Sadly (mea culpa) I'm not sure it's correct still.
I think this should be:

flow == eRender ? (
    role == eConsole ? (
        &default_render_device_id_ :
        &default_communications_render_device_id_
    ) : (
        role == eConsole ? (
            &default_capture_device_id_ :
            &default_communications_capture_device_id_
    );

Basically the |role| and |flow| variables were mixed up, not the constants :(

[Nico, 2014-07-28 22:55:35]

D'oh, sorry :-( Do you want me to send you a fix, or do you want to fix
yourself?


On Mon, Jul 28, 2014 at 3:48 PM, <tommi@chromium.org> wrote:

>
> https://codereview.chromium.org/419323002/diff/1/media/
> audio/win/audio_device_listener_win.cc
> File media/audio/win/audio_device_listener_win.cc (right):
>
> https://codereview.chromium.org/419323002/diff/1/media/
> audio/win/audio_device_listener_win.cc#newcode149
> media/audio/win/audio_device_listener_win.cc:149: role == eConsole ? (
> ehm, thanks for fixing this. Sadly (mea culpa) I'm not sure it's correct
> still.
> I think this should be:
>
> flow == eRender ? (
>
>     role == eConsole ? (
>         &default_render_device_id_ :
>         &default_communications_render_device_id_
>     ) : (
>
>         role == eConsole ? (
>             &default_capture_device_id_ :
>             &default_communications_capture_device_id_
>     );
>
> Basically the |role| and |flow| variables were mixed up, not the
> constants :(
>
> https://codereview.chromium.org/419323002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[Nico, 2014-07-28 22:55:36]

D'oh, sorry :-( Do you want me to send you a fix, or do you want to fix
yourself?


On Mon, Jul 28, 2014 at 3:48 PM, <tommi@chromium.org> wrote:

>
> https://codereview.chromium.org/419323002/diff/1/media/
> audio/win/audio_device_listener_win.cc
> File media/audio/win/audio_device_listener_win.cc (right):
>
> https://codereview.chromium.org/419323002/diff/1/media/
> audio/win/audio_device_listener_win.cc#newcode149
> media/audio/win/audio_device_listener_win.cc:149: role == eConsole ? (
> ehm, thanks for fixing this. Sadly (mea culpa) I'm not sure it's correct
> still.
> I think this should be:
>
> flow == eRender ? (
>
>     role == eConsole ? (
>         &default_render_device_id_ :
>         &default_communications_render_device_id_
>     ) : (
>
>         role == eConsole ? (
>             &default_capture_device_id_ :
>             &default_communications_capture_device_id_
>     );
>
> Basically the |role| and |flow| variables were mixed up, not the
> constants :(
>
> https://codereview.chromium.org/419323002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.