Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: chromeos/ime/component_extension_ime_manager.cc

Issue 419293002: IME refactoring: ChromeOS introduce input methods State. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/component_extension_ime_manager.cc
diff --git a/chromeos/ime/component_extension_ime_manager.cc b/chromeos/ime/component_extension_ime_manager.cc
index d34ef1904e56ed37010ce221ca72de2925dfcf72..8c7fbefdb5eb607ce0c426bde43cb7e07932e743 100644
--- a/chromeos/ime/component_extension_ime_manager.cc
+++ b/chromeos/ime/component_extension_ime_manager.cc
@@ -234,6 +234,9 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
const std::string& input_method_id,
ComponentExtensionIME* out_extension,
ComponentExtensionEngine* out_engine) {
+ // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+ // << input_method_id << "', out_extension=" << out_extension
+ // << ", out_engine=" << out_engine << "): Called.";
if (!extension_ime_util::IsComponentExtensionIME(input_method_id))
return false;
for (size_t i = 0; i < component_extension_imes_.size(); ++i) {
@@ -241,10 +244,20 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
const std::vector<ComponentExtensionEngine>& engines =
component_extension_imes_[i].engines;
+ // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+ // << input_method_id << "', out_extension=" << out_extension
+ // << ", out_engine=" << out_engine << "): checking extension IME
+ // number " << i << " .";
for (size_t j = 0; j < engines.size(); ++j) {
const std::string trial_ime_id =
extension_ime_util::GetComponentInputMethodID(
extension_id, engines[j].engine_id);
+ // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+ // << input_method_id << "', out_extension=" << out_extension
+ // << ", out_engine=" << out_engine << "): checking engine name='"
+ // << engines[j].display_name << "' trial_ime_id='" <<
+ // trial_ime_id << "'.";
+
if (trial_ime_id != input_method_id)
continue;
@@ -252,9 +265,15 @@ bool ComponentExtensionIMEManager::FindEngineEntry(
*out_extension = component_extension_imes_[i];
if (out_engine)
*out_engine = component_extension_imes_[i].engines[j];
+ // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+ // << input_method_id << "', out_extension=" << out_extension
+ // << ", out_engine=" << out_engine << "): Result is True.";
return true;
}
}
+ // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
+ // << input_method_id << "', out_extension=" << out_extension
+ // << ", out_engine=" << out_engine << "): Result is False.";
return false;
}

Powered by Google App Engine
This is Rietveld 408576698