Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: chromeos/ime/component_extension_ime_manager.cc

Issue 419293002: IME refactoring: ChromeOS introduce input methods State. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/ime/component_extension_ime_manager.h" 5 #include "chromeos/ime/component_extension_ime_manager.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "chromeos/ime/extension_ime_util.h" 9 #include "chromeos/ime/extension_ime_util.h"
10 10
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 } 227 }
228 228
229 void ComponentExtensionIMEManager::RemoveObserver(Observer* observer) { 229 void ComponentExtensionIMEManager::RemoveObserver(Observer* observer) {
230 observers_.RemoveObserver(observer); 230 observers_.RemoveObserver(observer);
231 } 231 }
232 232
233 bool ComponentExtensionIMEManager::FindEngineEntry( 233 bool ComponentExtensionIMEManager::FindEngineEntry(
234 const std::string& input_method_id, 234 const std::string& input_method_id,
235 ComponentExtensionIME* out_extension, 235 ComponentExtensionIME* out_extension,
236 ComponentExtensionEngine* out_engine) { 236 ComponentExtensionEngine* out_engine) {
237 // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
238 // << input_method_id << "', out_extension=" << out_extension
239 // << ", out_engine=" << out_engine << "): Called.";
237 if (!extension_ime_util::IsComponentExtensionIME(input_method_id)) 240 if (!extension_ime_util::IsComponentExtensionIME(input_method_id))
238 return false; 241 return false;
239 for (size_t i = 0; i < component_extension_imes_.size(); ++i) { 242 for (size_t i = 0; i < component_extension_imes_.size(); ++i) {
240 const std::string extension_id = component_extension_imes_[i].id; 243 const std::string extension_id = component_extension_imes_[i].id;
241 const std::vector<ComponentExtensionEngine>& engines = 244 const std::vector<ComponentExtensionEngine>& engines =
242 component_extension_imes_[i].engines; 245 component_extension_imes_[i].engines;
243 246
247 // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
248 // << input_method_id << "', out_extension=" << out_extension
249 // << ", out_engine=" << out_engine << "): checking extension IME
250 // number " << i << " .";
244 for (size_t j = 0; j < engines.size(); ++j) { 251 for (size_t j = 0; j < engines.size(); ++j) {
245 const std::string trial_ime_id = 252 const std::string trial_ime_id =
246 extension_ime_util::GetComponentInputMethodID( 253 extension_ime_util::GetComponentInputMethodID(
247 extension_id, engines[j].engine_id); 254 extension_id, engines[j].engine_id);
255 // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
256 // << input_method_id << "', out_extension=" << out_extension
257 // << ", out_engine=" << out_engine << "): checking engine name='"
258 // << engines[j].display_name << "' trial_ime_id='" <<
259 // trial_ime_id << "'.";
260
248 if (trial_ime_id != input_method_id) 261 if (trial_ime_id != input_method_id)
249 continue; 262 continue;
250 263
251 if (out_extension) 264 if (out_extension)
252 *out_extension = component_extension_imes_[i]; 265 *out_extension = component_extension_imes_[i];
253 if (out_engine) 266 if (out_engine)
254 *out_engine = component_extension_imes_[i].engines[j]; 267 *out_engine = component_extension_imes_[i].engines[j];
268 // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
269 // << input_method_id << "', out_extension=" << out_extension
270 // << ", out_engine=" << out_engine << "): Result is True.";
255 return true; 271 return true;
256 } 272 }
257 } 273 }
274 // LOG(ERROR) << "ComponentExtensionIMEManager::FindEngineEntry('"
275 // << input_method_id << "', out_extension=" << out_extension
276 // << ", out_engine=" << out_engine << "): Result is False.";
258 return false; 277 return false;
259 } 278 }
260 279
261 bool ComponentExtensionIMEManager::IsInLoginLayoutWhitelist( 280 bool ComponentExtensionIMEManager::IsInLoginLayoutWhitelist(
262 const std::vector<std::string>& layouts) { 281 const std::vector<std::string>& layouts) {
263 for (size_t i = 0; i < layouts.size(); ++i) { 282 for (size_t i = 0; i < layouts.size(); ++i) {
264 if (login_layout_set_.find(layouts[i]) != login_layout_set_.end()) 283 if (login_layout_set_.find(layouts[i]) != login_layout_set_.end())
265 return true; 284 return true;
266 } 285 }
267 return false; 286 return false;
268 } 287 }
269 288
270 } // namespace chromeos 289 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698