Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

Issue 419263002: Add ManagePasswordsDecoration and unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
index 45cc29b1af752b8211a17c2193cfb35f90b0bc46..e19c35526ea9df2e58dd57112ad540020d8c5add 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
@@ -28,6 +28,7 @@ class GeneratedCreditCardDecoration;
class KeywordHintDecoration;
class LocationBarDecoration;
class LocationIconDecoration;
+class ManagePasswordsDecoration;
class MicSearchDecoration;
class OriginChipDecoration;
class PageActionDecoration;
@@ -64,7 +65,7 @@ class LocationBarViewMac : public LocationBar,
virtual void FocusLocation(bool select_all) OVERRIDE;
virtual void FocusSearch() OVERRIDE;
virtual void UpdateContentSettingsIcons() OVERRIDE;
- virtual void UpdateManagePasswordsIconAndBubble() OVERRIDE {};
+ virtual void UpdateManagePasswordsIconAndBubble() OVERRIDE;
virtual void UpdatePageActions() OVERRIDE;
virtual void InvalidatePageActions() OVERRIDE;
virtual void UpdateOpenPDFInReaderPrompt() OVERRIDE;
@@ -111,6 +112,10 @@ class LocationBarViewMac : public LocationBar,
// aim at.
NSPoint GetTranslateBubblePoint() const;
+ // Get the point in window coordinates in the lock icon for the Manage
+ // Passwords bubble to aim at.
+ NSPoint GetManagePasswordsBubblePoint() const;
rohitrao (ping after 24h) 2014/07/31 12:35:19 Is this function actually called anywhere? I woul
dconnelly 2014/08/01 09:11:46 It's used, but not in this CL. I'll move it to a f
+
// Get the point in window coordinates in the security icon at which the page
// info bubble aims.
NSPoint GetPageInfoBubblePoint() const;
@@ -266,6 +271,9 @@ class LocationBarViewMac : public LocationBar,
// The left-hand-side origin chip.
scoped_ptr<OriginChipDecoration> origin_chip_decoration_;
+ // The right-hand-side button to manage passwords associated with a page.
+ scoped_ptr<ManagePasswordsDecoration> manage_passwords_decoration_;
+
Browser* browser_;
// Used to register for notifications received by NotificationObserver.

Powered by Google App Engine
This is Rietveld 408576698