Add ManagePasswordsDecoration and unit tests.

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_
 #define CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_
 
 #include <string>
 
 #import <Cocoa/Cocoa.h>
@@ skipping 10 matching lines @@
 #include "components/content_settings/core/common/content_settings_types.h"
 
 @class AutocompleteTextField;
 class CommandUpdater;
 class ContentSettingDecoration;
 class EVBubbleDecoration;
 class GeneratedCreditCardDecoration;
 class KeywordHintDecoration;
 class LocationBarDecoration;
 class LocationIconDecoration;
+class ManagePasswordsDecoration;
 class MicSearchDecoration;
 class OriginChipDecoration;
 class PageActionDecoration;
 class Profile;
 class SearchButtonDecoration;
 class SelectedKeywordDecoration;
 class StarDecoration;
 class TranslateDecoration;
 class ZoomDecoration;
 class ZoomDecorationTest;
@@ skipping 16 matching lines @@
 
   // Overridden from LocationBar:
   virtual void ShowFirstRunBubble() OVERRIDE;
   virtual GURL GetDestinationURL() const OVERRIDE;
   virtual WindowOpenDisposition GetWindowOpenDisposition() const OVERRIDE;
   virtual content::PageTransition GetPageTransition() const OVERRIDE;
   virtual void AcceptInput() OVERRIDE;
   virtual void FocusLocation(bool select_all) OVERRIDE;
   virtual void FocusSearch() OVERRIDE;
   virtual void UpdateContentSettingsIcons() OVERRIDE;
-  virtual void UpdateManagePasswordsIconAndBubble() OVERRIDE {};
+  virtual void UpdateManagePasswordsIconAndBubble() OVERRIDE;
   virtual void UpdatePageActions() OVERRIDE;
   virtual void InvalidatePageActions() OVERRIDE;
   virtual void UpdateOpenPDFInReaderPrompt() OVERRIDE;
   virtual void UpdateGeneratedCreditCardView() OVERRIDE;
   virtual void SaveStateToContents(content::WebContents* contents) OVERRIDE;
   virtual void Revert() OVERRIDE;
   virtual const OmniboxView* GetOmniboxView() const OVERRIDE;
   virtual OmniboxView* GetOmniboxView() OVERRIDE;
   virtual LocationBarTesting* GetLocationBarForTesting() OVERRIDE;
 
@@ skipping 26 matching lines @@
   bool IsStarEnabled() const;
 
   // Get the point in window coordinates on the star for the bookmark bubble to
   // aim at. Only works if IsStarEnabled returns YES.
   NSPoint GetBookmarkBubblePoint() const;
 
   // Get the point in window coordinates on the star for the Translate bubble to
   // aim at.
   NSPoint GetTranslateBubblePoint() const;
 
+  // Get the point in window coordinates in the lock icon for the Manage
+  // Passwords bubble to aim at.
+  NSPoint GetManagePasswordsBubblePoint() const;

[rohitrao (ping after 24h), 2014/07/31 12:35:19]

Is this function actually called anywhere?  I would leave it out if it's never
used.

[dconnelly, 2014/08/01 09:11:46]

It's used, but not in this CL. I'll move it to a follow-up CL.

+
   // Get the point in window coordinates in the security icon at which the page
   // info bubble aims.
   NSPoint GetPageInfoBubblePoint() const;
 
   // Get the point in window coordinates in the "generated cc" icon at which the
   // corresponding info bubble aims.
   NSPoint GetGeneratedCreditCardBubblePoint() const;
 
   // When any image decorations change, call this to ensure everything is
   // redrawn and laid out if necessary.
@@ skipping 135 matching lines @@
 
   // Generated CC hint decoration.
   scoped_ptr<GeneratedCreditCardDecoration> generated_credit_card_decoration_;
 
   // The right-hand-side search button that is shown on search result pages.
   scoped_ptr<SearchButtonDecoration> search_button_decoration_;
 
   // The left-hand-side origin chip.
   scoped_ptr<OriginChipDecoration> origin_chip_decoration_;
 
+  // The right-hand-side button to manage passwords associated with a page.
+  scoped_ptr<ManagePasswordsDecoration> manage_passwords_decoration_;
+
   Browser* browser_;
 
   // Used to register for notifications received by NotificationObserver.
   content::NotificationRegistrar registrar_;
 
   // Used to schedule a task for the first run info bubble.
   base::WeakPtrFactory<LocationBarViewMac> weak_ptr_factory_;
 
   // Used to change the visibility of the star decoration.
   BooleanPrefMember edit_bookmarks_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(LocationBarViewMac);
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_LOCATION_BAR_LOCATION_BAR_VIEW_MAC_H_