Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: Source/core/dom/Document.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/AddConsoleMessageTask.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 286a5d8cf70c4ebcfd02f450d0da638078867a3c..3cb52b61aab4ab5965f7ea790970ba2c1d92839f 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -46,6 +46,7 @@
#include "core/dom/ViewportDescription.h"
#include "core/dom/custom/CustomElement.h"
#include "core/html/CollectionType.h"
+#include "core/inspector/ConsoleMessage.h"
vsevik 2014/08/08 17:04:00 Forward declaration here?
kozyatinskiy1 2014/08/08 17:17:00 Done.
#include "core/page/FocusType.h"
#include "core/page/PageVisibilityState.h"
#include "platform/Length.h"
@@ -1012,7 +1013,7 @@ public:
void didAssociateFormControl(Element*);
- void addConsoleMessageWithRequestIdentifier(MessageSource, MessageLevel, const String& message, unsigned long requestIdentifier);
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
virtual LocalDOMWindow* executingWindow() OVERRIDE FINAL;
LocalFrame* executingFrame();
@@ -1115,8 +1116,6 @@ private:
virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL; // Same as completeURL() for the same reason as above.
virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) OVERRIDE FINAL;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState*) OVERRIDE FINAL;
- void internalAddMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>, ScriptState*);
virtual double timerAlignmentInterval() const OVERRIDE FINAL;
« no previous file with comments | « Source/core/dom/AddConsoleMessageTask.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698