Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419073003: gn win: Fix sdch force-include (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : slightly less ugly fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdch/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
6 years, 5 months ago (2014-07-24 22:48:39 UTC) #1
brettw
This is offensive. LGTM
6 years, 5 months ago (2014-07-25 04:50:25 UTC) #2
scottmg
On 2014/07/25 04:50:25, brettw wrote: > This is offensive. LGTM I actually don't understand why ...
6 years, 5 months ago (2014-07-25 04:53:18 UTC) #3
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-25 04:53:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/419073003/1
6 years, 5 months ago (2014-07-25 04:53:53 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 06:15:52 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 06:18:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82321)
6 years, 5 months ago (2014-07-25 06:18:59 UTC) #8
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 4 months ago (2014-07-29 17:36:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/419073003/20001
6 years, 4 months ago (2014-07-29 17:36:47 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 21:23:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 286293

Powered by Google App Engine
This is Rietveld 408576698