Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdch/BUILD.gn

Issue 419073003: gn win: Fix sdch force-include (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: slightly less ugly fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdch/BUILD.gn
diff --git a/sdch/BUILD.gn b/sdch/BUILD.gn
index 927831822436d4a09a31ae641892e4e23b758842..fe6cba89933c0af54ef9a7a158b4fa1665565207 100644
--- a/sdch/BUILD.gn
+++ b/sdch/BUILD.gn
@@ -62,12 +62,12 @@ static_library("sdch") {
# Inject a header that forwards to base/logging.h instead (which doesn't
# introduce static initializers, and which prevents open-vcdiff's
# logging.h from being used).
- logging_file = rebase_path("logging_forward.h", root_build_dir)
if (is_win) {
cflags = [
- "/FI", logging_file,
+ "/FI", "sdch/logging_forward.h",
]
} else {
+ logging_file = rebase_path("logging_forward.h", root_build_dir)
cflags = [ "-include", logging_file ]
if (is_linux) {
# TODO(mostynb): remove this if open-vcdiff is ever updated for c++11:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698