Fix crash in HTMLInputElement::setupDateTimeChooserParameters

Fix crash in HTMLInputElement::setupDateTimeChooserParameters

The date time input element has a custom style, meaning that computedStyle will not work here. So delegate the decision, so the input type can do the right thing.

BUG=384591
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179411

[rwlbuis, 2014-07-30 22:33:24]

PTAL. I started with the obvious fix of providing nonRenderStyle() for
HTMLInputElement, since we also have customStyleForRenderer, but it turns out a
lot of plumbing would be needed, including three virtual methods being added to
InputType and delegating to it in HTMLInputElement attach/detach.

[tkent, 2014-07-30 23:19:58]

https://codereview.chromium.org/419053005/diff/1/LayoutTests/fast/forms/datep...
File LayoutTests/fast/forms/datepicker-crash-after-keydown.html (right):

https://codereview.chromium.org/419053005/diff/1/LayoutTests/fast/forms/datep...
LayoutTests/fast/forms/datepicker-crash-after-keydown.html:1: <input id="month"
type="month"</div>
- The top level indentation is not helpful.
- Please move this to fast/forms/calendar-picker/.

https://codereview.chromium.org/419053005/diff/1/Source/core/html/forms/BaseM...
File Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h (right):

https://codereview.chromium.org/419053005/diff/1/Source/core/html/forms/BaseM...
Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h:118: virtual
TextDirection computedTextDirection();
should have OVERRIDE FINAL

[tkent, 2014-07-30 23:21:49]

> UNKNOWN in WebCore::RenderStyle::direction

This CL summary is unclear.
Probably "Fix crash in HTMLInputElement::setupDateTimeChooserParameters" or
something?

[rwlbuis, 2014-07-31 15:45:27]

PTAL, all issues should be fixed now.

[tkent, 2014-08-01 00:10:39]

lgtm

https://codereview.chromium.org/419053005/diff/20001/LayoutTests/fast/forms/c...
File LayoutTests/fast/forms/calendar-picker/datepicker-crash-after-keydown.html
(right):

https://codereview.chromium.org/419053005/diff/20001/LayoutTests/fast/forms/c...
LayoutTests/fast/forms/calendar-picker/datepicker-crash-after-keydown.html:3: if
(window.testRunner) {
nit: The top-level indentation is not helpful.

[rwlbuis, 2014-08-01 15:16:38]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-08-01 15:17:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/419053005/40001

[commit-bot: I haz the power, 2014-08-01 16:32:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20164)

[commit-bot: I haz the power, 2014-08-01 17:38:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 17:38:15]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[rwlbuis, 2014-08-01 17:42:51]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-08-01 17:44:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rob.buis@samsung.com/419053005/40001

[commit-bot: I haz the power, 2014-08-01 18:53:34]

Change committed as 179411