Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Side by Side Diff: Source/core/html/forms/InputType.cpp

Issue 419053005: Fix crash in HTMLInputElement::setupDateTimeChooserParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/InputType.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 9 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
10 * 10 *
(...skipping 765 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 unsigned InputType::height() const 776 unsigned InputType::height() const
777 { 777 {
778 return 0; 778 return 0;
779 } 779 }
780 780
781 unsigned InputType::width() const 781 unsigned InputType::width() const
782 { 782 {
783 return 0; 783 return 0;
784 } 784 }
785 785
786 TextDirection InputType::computedTextDirection()
787 {
788 return element().computedStyle()->direction();
789 }
790
786 void InputType::applyStep(const Decimal& current, int count, AnyStepHandling any StepHandling, TextFieldEventBehavior eventBehavior, ExceptionState& exceptionSta te) 791 void InputType::applyStep(const Decimal& current, int count, AnyStepHandling any StepHandling, TextFieldEventBehavior eventBehavior, ExceptionState& exceptionSta te)
787 { 792 {
788 StepRange stepRange(createStepRange(anyStepHandling)); 793 StepRange stepRange(createStepRange(anyStepHandling));
789 if (!stepRange.hasStep()) { 794 if (!stepRange.hasStep()) {
790 exceptionState.throwDOMException(InvalidStateError, "This form element d oes not have an allowed value step."); 795 exceptionState.throwDOMException(InvalidStateError, "This form element d oes not have an allowed value step.");
791 return; 796 return;
792 } 797 }
793 798
794 EventQueueScope scope; 799 EventQueueScope scope;
795 const Decimal step = stepRange.step(); 800 const Decimal step = stepRange.step();
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
959 StepRange InputType::createStepRange(AnyStepHandling anyStepHandling, const Deci mal& stepBaseDefault, const Decimal& minimumDefault, const Decimal& maximumDefau lt, const StepRange::StepDescription& stepDescription) const 964 StepRange InputType::createStepRange(AnyStepHandling anyStepHandling, const Deci mal& stepBaseDefault, const Decimal& minimumDefault, const Decimal& maximumDefau lt, const StepRange::StepDescription& stepDescription) const
960 { 965 {
961 const Decimal stepBase = findStepBase(stepBaseDefault); 966 const Decimal stepBase = findStepBase(stepBaseDefault);
962 const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), m inimumDefault); 967 const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), m inimumDefault);
963 const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), m aximumDefault); 968 const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), m aximumDefault);
964 const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element().fastGetAttribute(stepAttr)); 969 const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element().fastGetAttribute(stepAttr));
965 return StepRange(stepBase, minimum, maximum, step, stepDescription); 970 return StepRange(stepBase, minimum, maximum, step, stepDescription);
966 } 971 }
967 972
968 } // namespace blink 973 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/forms/InputType.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698