Issue 419: Fix a crash caused by a NULL FILETIME when creating ftp...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 419: Fix a crash caused by a NULL FILETIME when creating ftp... (Closed)

Created:
12 years, 4 months ago by tony

Modified:
9 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash caused by a NULL FILETIME when creating ftp directory listings. BUG=1350006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1722

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -3 lines)			Patch
	M	net/base/net_util.cc	View		1 chunk	+7 lines, -3 lines	1 comment	Download
	M	net/base/net_util_unittest.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/419/diff/1/2 File net/base/net_util.cc (right): http://codereview.chromium.org/419/diff/1/2#newcode828 Line 828: string_escape::JavascriptDoubleQuote(modified_str, true, &result); Can all the code be ...

12 years, 4 months ago (2008-09-03 18:48:48 UTC) #2

Okay, I get it.

LGTM

Expand Messages | Collapse Messages