Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 419: Fix a crash caused by a NULL FILETIME when creating ftp... (Closed)

Created:
10 years, 6 months ago by tony
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a crash caused by a NULL FILETIME when creating ftp directory listings. BUG=1350006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M net/base/net_util.cc View 1 chunk +7 lines, -3 lines 1 comment Download
M net/base/net_util_unittest.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
10 years, 6 months ago (2008-09-03 18:14:09 UTC) #1
brettw
http://codereview.chromium.org/419/diff/1/2 File net/base/net_util.cc (right): http://codereview.chromium.org/419/diff/1/2#newcode828 Line 828: string_escape::JavascriptDoubleQuote(modified_str, true, &result); Can all the code be ...
10 years, 6 months ago (2008-09-03 18:48:48 UTC) #2
brettw
10 years, 6 months ago (2008-09-04 18:19:21 UTC) #3
Okay, I get it.

LGTM

Powered by Google App Engine
This is Rietveld 408576698