Fix a crash caused by a NULL FILETIME when creating ftp...

net/base/net_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <unicode/ucnv.h>
 #include <unicode/uidna.h>
 #include <unicode/ulocdata.h>
 #include <unicode/uniset.h>
 #include <unicode/uscript.h>
@@ skipping 801 matching lines @@
     result.append(",1,");
   } else {
     result.append(",0,");
   }
 
   string_escape::JavascriptDoubleQuote(
       FormatBytes(size, GetByteDisplayUnits(size), true), true, &result);
 
   result.append(",");
 
-  Time time(Time::FromFileTime(*modified));
-  string_escape::JavascriptDoubleQuote(base::TimeFormatShortDateAndTime(time),
-      true, &result);
+  std::wstring modified_str;
+  // |modified| can be NULL in FTP listings.
+  if (modified) {
+    Time time(Time::FromFileTime(*modified));
+    modified_str = base::TimeFormatShortDateAndTime(time);
+  }
+  string_escape::JavascriptDoubleQuote(modified_str, true, &result);

[brettw, 2008/09/03 18:48:48]

Can all the code be moved inside the if statement?

 
   result.append(");</script>\n");
 
   return result;
 }
 #endif
 
 std::wstring StripWWW(const std::wstring& text) {
   const std::wstring www(L"www.");
   return (text.compare(0, www.length(), www) == 0) ?
@@ skipping 63 matching lines @@
     if (kAllowedFtpPorts[i] == port) {
         return true;
     }
   }
   // Port not explicitly allowed by FTP, so return the default restrictions.
   return IsPortAllowedByDefault(port);
 }
 
 }  // namespace net