Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 418943003: Close "Internet Settings" key in the sandbox (Closed)

Created:
6 years, 5 months ago by jschuh
Modified:
6 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Close "Internet Settings" key in the sandbox BUG=349162 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285441

Patch Set 1 #

Total comments: 2

Patch Set 2 : version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/common/sandbox_win.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jschuh
ptal
6 years, 5 months ago (2014-07-24 20:25:02 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/418943003/diff/1/content/common/sandbox_win.cc File content/common/sandbox_win.cc (right): https://codereview.chromium.org/418943003/diff/1/content/common/sandbox_win.cc#newcode356 content/common/sandbox_win.cc:356: policy->AddKernelObjectToClose(L"Key", use less than 2003
6 years, 5 months ago (2014-07-24 20:38:49 UTC) #2
jschuh
https://codereview.chromium.org/418943003/diff/1/content/common/sandbox_win.cc File content/common/sandbox_win.cc (right): https://codereview.chromium.org/418943003/diff/1/content/common/sandbox_win.cc#newcode356 content/common/sandbox_win.cc:356: policy->AddKernelObjectToClose(L"Key", On 2014/07/24 20:38:49, cpu wrote: > use less ...
6 years, 5 months ago (2014-07-24 20:47:21 UTC) #3
jschuh
The CQ bit was checked by jschuh@chromium.org
6 years, 5 months ago (2014-07-24 20:47:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/418943003/20001
6 years, 5 months ago (2014-07-24 20:50:32 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:43:36 UTC) #6
Message was sent while issue was closed.
Change committed as 285441

Powered by Google App Engine
This is Rietveld 408576698